hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Shelukhin <ser...@hortonworks.com>
Subject Re: Extensions for patches accepted by QA bot
Date Wed, 04 Dec 2013 01:10:34 GMT
Hive QA has a more strict filter, which can also be used to test patches
against specific branch: "Upload a patch to a JIRA in the following format
HIVE-XXXX.patch, HIVE-XXXX.XX.patch, HIVE-XXXX.DXXXX.XX.patch
(phabricator), or HIVE-XXXX-branch.patch (allows targeting a branch)."
https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing

I think it is a good idea... people attach all kinds of stuff to jira


On Tue, Dec 3, 2013 at 5:07 PM, Nick Dimiduk <ndimiduk@gmail.com> wrote:

> I don't think that's a necessary filter; it'll still get false-positives
> like HBASE-1234_design_v1.txt. I'd prefer the automation to be kind and
> understanding in accepting and evaluating community contributions :)
> Running failing to apply a non-patch doesn't really hurt anything.
>
>
> On Tue, Dec 3, 2013 at 9:51 AM, Ted Yu <yuzhihong@gmail.com> wrote:
>
> > Over in HBASE-10017, the following attachment triggered a QA warning:
> >
> >
> http://issues.apache.org/jira/secure/attachment/12616816/patchSiteOutput.txt
> >
> > Should the acceptance criteria include the notion that there should be
> JIRA
> > number in the filename ?
> >
> > Thanks
> >
> >
> > On Tue, Dec 3, 2013 at 12:39 AM, Anoop John <anoop.hbase@gmail.com>
> wrote:
> >
> > > +1 for .patch, .txt, .diff
> > >
> > > -Anoop-
> > >
> > > On Tue, Dec 3, 2013 at 6:16 AM, Nick Dimiduk <ndimiduk@gmail.com>
> wrote:
> > >
> > > > Sounds reasonable to me. Maybe add .diff to that list?
> > > >
> > > >
> > > > On Mon, Dec 2, 2013 at 4:34 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> > > >
> > > > > During review of
> > > > >   HBASE-10044 test-patch.sh should filter out documents by known
> file
> > > > > extensions
> > > > > Jesse made the suggestion that QA bot only accepts files with
> > > extensions
> > > > > .patch
> > > > > and .txt
> > > > >
> > > > > I want to get opinion from the community on this matter.
> > > > >
> > > > > Thanks
> > > > >
> > > >
> > >
> >
>

-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message