Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of kashifjs@huawei.com
 designates 119.145.14.64 as permitted sender)
From: Kashif Jawed Siddiqui <kashifjs@huawei.com>
To: "dev@hbase.apache.org" <dev@hbase.apache.org>
Subject: Region Server is starting normally even if clock skew is more than
 default 30 seconds(or any configured). -> Regionserver node time is greater
 than master node time
Thread-Topic: Region Server is starting normally even if clock skew is more
 than default 30 seconds(or any configured). -> Regionserver node time is
 greater than master node time
Thread-Index: Ac7a+at6B86WbdzKSpO19djxIm55ZA==
Date: Wed, 6 Nov 2013 14:11:36 +0000
Message-ID: 
 <3FEC773ED933774285EE811E6F24DF7A5F0CE057@szxeml521-mbx.china.huawei.com>
Accept-Language: en-US, zh-CN
Content-Language: en-US
Content-Type: multipart/alternative;
	boundary="_000_3FEC773ED933774285EE811E6F24DF7A5F0CE057szxeml521mbxchi_"
MIME-Version: 1.0

--_000_3FEC773ED933774285EE811E6F24DF7A5F0CE057szxeml521mbxchi_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi,


    When Region server's time is ahead of Master's time and the difference =
is more than hbase.master.maxclockskew value, region server startup is not =
failing with ClockOutOfSyncException.


    ServerManager.java#checkClockSkew


          long skew =3D System.currentTimeMillis() - serverCurrentTime;
        if (skew > maxSkew) {
          String message =3D "Server " + serverName + " has been " +
            "rejected; Reported time is too far out of sync with master.  "=
 +
            "Time difference of " + skew + "ms > max allowed of " + maxSkew=
 + "ms";
          LOG.warn(message);
          throw new ClockOutOfSyncException(message);
        }


    Above line results in negative value when Master's time is lesser than =
region server time and  " if (skew > maxSkew) " check fails to find the ske=
w in this case.


    I will be raising an Issue in JIRA for fixing the same. Please let me k=
now if any concerns.


    Please Note: This was tested in hbase 0.94.11 version and the trunk als=
o currently has the same logic.


Regards,
Kashif Jawed Siddiqui
***************************************************************************=
************
This e-mail and attachments contain confidential information from HUAWEI, w=
hich is intended only for the person or entity whose address is listed abov=
e. Any use of the information contained herein in any way (including, but n=
ot limited to, total or partial disclosure, reproduction, or dissemination)=
 by persons other than the intended recipient's) is prohibited. If you rece=
ive this e-mail in error, please notify the sender by phone or email immedi=
ately and delete it!

--_000_3FEC773ED933774285EE811E6F24DF7A5F0CE057szxeml521mbxchi_--