hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-9411) Increment / decrement of rpcCount in RpcServer#Connection is not protected by synchronization
Date Mon, 02 Sep 2013 15:23:51 GMT
Ted Yu created HBASE-9411:
-----------------------------

             Summary: Increment / decrement of rpcCount in RpcServer#Connection is not protected
by synchronization
                 Key: HBASE-9411
                 URL: https://issues.apache.org/jira/browse/HBASE-9411
             Project: HBase
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


Here is related code:
{code}
    /* Decrement the outstanding RPC count */
    protected void decRpcCount() {
      rpcCount--;
    }

    /* Increment the outstanding RPC count */
    protected void incRpcCount() {
      rpcCount++;
    }
{code}
Even though rpcCount is volatile, in non atomic operations (increment / decrement) different
threads may get unexpected result.

See http://stackoverflow.com/questions/7805192/is-a-volatile-int-in-java-thread-safe

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message