Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1E65210939 for ; Tue, 16 Jul 2013 08:36:42 +0000 (UTC) Received: (qmail 97117 invoked by uid 500); 16 Jul 2013 08:36:41 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 96871 invoked by uid 500); 16 Jul 2013 08:36:40 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 96863 invoked by uid 99); 16 Jul 2013 08:36:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2013 08:36:38 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of lars.george@gmail.com designates 209.85.220.46 as permitted sender) Received: from [209.85.220.46] (HELO mail-pa0-f46.google.com) (209.85.220.46) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2013 08:36:32 +0000 Received: by mail-pa0-f46.google.com with SMTP id fa11so540477pad.5 for ; Tue, 16 Jul 2013 01:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:subject:date:references:to:message-id :mime-version:x-mailer; bh=w3E0FoeKStdLJvJbxngNsI7J0FeDel3kSOeM7s0q9Jk=; b=JwpbQpU2rgYg0+fAaekCvJ5OIK2jApBZGxOgNIdj+UBnGZya0x4g/P7oYJRfB3/h+F iUzbGAtFFjgrnCv5wQxRTADtbnubuTxCt6/Kcn8Ko2KV5KPG0XPwtijXHHt2mapdx2mT +iCmAEEZmYMHx4CWnq94+SDgptoG9vbpsYBs33zVxjH9mCxTY0wsBr0ItaOOx0nwIGGH qFeUHI76fiFxe0Y2xNw4+nI3IhqNjkWOyefE2yhBnganHNObg3PJEq7ywiNo6/LlY04i dhGEvb1xHLBkqfJKKZaYJirx6/EhjZKmXQ2/kIBjj7leiCARerkQeqTpTqWCMsAUe/34 wZzA== X-Received: by 10.66.50.104 with SMTP id b8mr1600356pao.39.1373963770622; Tue, 16 Jul 2013 01:36:10 -0700 (PDT) Received: from [10.0.0.56] (p4FEBDEA4.dip0.t-ipconnect.de. [79.235.222.164]) by mx.google.com with ESMTPSA id p2sm2958535pag.22.2013.07.16.01.36.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 16 Jul 2013 01:36:08 -0700 (PDT) From: Lars George Content-Type: multipart/alternative; boundary="Apple-Mail=_AD7C8877-AB14-45CC-AE59-2488CE2A120F" Subject: Fwd: [jira] [Commented] (HBASE-8943) Split Thrift2's ThriftServer into separate classes for easier testing and modularization Date: Tue, 16 Jul 2013 10:36:03 +0200 References: To: "dev@hbase.apache.org" , Stack Message-Id: <106407EB-AE1A-4225-914F-BAF5D7764999@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) X-Mailer: Apple Mail (2.1508) X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail=_AD7C8877-AB14-45CC-AE59-2488CE2A120F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Did this get committed with the wrong JIRA number? Begin forwarded message: > From: "Hudson (JIRA)" > Subject: [jira] [Commented] (HBASE-8943) Split Thrift2's ThriftServer = into separate classes for easier testing and modularization > Date: July 16, 2013 2:44:55 AM GMT+02:00 > To: issues@hbase.apache.org >=20 >=20 > [ = https://issues.apache.org/jira/browse/HBASE-8943?page=3Dcom.atlassian.jira= .plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13709294= #comment-13709294 ]=20 >=20 > Hudson commented on HBASE-8943: > ------------------------------- >=20 > FAILURE: Integrated in hbase-0.95-on-hadoop2 #180 (See = [https://builds.apache.org/job/hbase-0.95-on-hadoop2/180/]) > HBASE-8943 TestRegionMergeTransactionOnCluster#testWholesomeMerge may = fail due to race in opening region (stack: rev 1503471) > * = /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ma= ster/handler/DispatchMergingRegionHandler.java >=20 >=20 >> Split Thrift2's ThriftServer into separate classes for easier testing = and modularization >> = --------------------------------------------------------------------------= -------------- >>=20 >> Key: HBASE-8943 >> URL: https://issues.apache.org/jira/browse/HBASE-8943 >> Project: HBase >> Issue Type: Sub-task >> Components: Thrift >> Reporter: Lars George >> Assignee: Lars George >> Labels: thrift2 >>=20 >> Currently the ThriftServer class in Thrift 2 sets up and starts the = actual server. Better follow a similar pattern to Thrift 1 where there = is some factory setting up the server, and a separate start section. = That way it is easier to test if the setup of the server is picking up = everything it needs. >=20 > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA = administrators > For more information on JIRA, see: = http://www.atlassian.com/software/jira --Apple-Mail=_AD7C8877-AB14-45CC-AE59-2488CE2A120F--