hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-8852) Close scanners when at end in Thrift 2
Date Tue, 16 Jul 2013 17:58:48 GMT

     [ https://issues.apache.org/jira/browse/HBASE-8852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lars George resolved HBASE-8852.
--------------------------------

    Resolution: Won't Fix
      Assignee: Lars George

I am closing this for now in favor of HBASE-8946. Here we have an issue removing the scanner
at the end implicitly. We could - for example - at least release the resources, i.e. close
the ClientScanner instance. But that is covered in the linked issues at a broader scope.
                
> Close scanners when at end in Thrift 2
> --------------------------------------
>
>                 Key: HBASE-8852
>                 URL: https://issues.apache.org/jira/browse/HBASE-8852
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: Lars George
>            Assignee: Lars George
>              Labels: thrift2
>
> HBASE-6073 adds the following to the overall patch:
> {code}
> -      return resultsFromHBase(scanner.next(numRows));
> +      List<TResult> results = resultsFromHBase(scanner.next(numRows));
> +      if(results.size() < numRows) {
> +        removeScanner(scannerId);
> +      }
> +      return results;
> {code}
> We need to see if we have to add this to Thrift2 as separate patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message