hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas Liochon <nkey...@gmail.com>
Subject Re: Extend the Hadoop QA bot to handle dependencies
Date Thu, 11 Jul 2013 09:55:35 GMT
Yes, it's a good idea.
It seems feasible. The code executed by HadoopQA is in the hbase repo in
dev-support/test-patch.sh, so we control it. It's easy to add  tests there.
One thing to take care about however is how long it takes to do that. maven
plugins are surprising sometimes.
As well, if the plugin outputs cleanly the undeclared dependencies, we
could just fix them all at the beginning instead of doing a diff. We did
this for the javadoc warnings, and it worked.



On Thu, Jul 11, 2013 at 11:27 AM, Lars Francke <lars.francke@gmail.com>wrote:

> Hi,
> I don't know much (basically nothing) about how the Hadoop QA bot is
> implemented but I have a suggestion for how it could be improved and
> would like some opinions and maybe pointers.
> Maven and dependency handling is a topic not very many people find
> interesting. Understandably. But that means that often people
> introduce dependencies without declaring them in the pom file (see
> HBASE-8917[1] for one example but we had this problem before, years
> ago). That often leads to weird errors at some point when an upstream
> dependency changes.
> There's a plugin[2] that can analyze dependencies and their usage and
> report unused dependencies and used but undeclared ones (it's not
> perfect but good enough). I think it'd be great if the Hadoop QA bot
> could analyze a before and after snapshot of the output of this plugin
> and do a -1 if anyone introduces a new dependency without declaring
> it.
> Does that sound like a good idea?
> Cheers,
> Lars
> [1] <https://issues.apache.org/jira/browse/HBASE-8917>
> [2] <
> http://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.html>

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message