Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Date: Thu, 28 Feb 2013 01:42:12 +0000 (UTC)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: dev@hbase.apache.org
Message-ID: <JIRA.12634539.1362015637578.354777.1362015732179@arcas>
In-Reply-To: <JIRA.12634539.1362015637578@arcas>
References: <JIRA.12634539.1362015637578@arcas>
Subject: [jira] [Created] (HBASE-7957) CloneSnapshotHandler.prepare() is not
 called by SnapshotManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Enis Soztutar created HBASE-7957:
------------------------------------

             Summary: CloneSnapshotHandler.prepare() is not called by SnapshotManager
                 Key: HBASE-7957
                 URL: https://issues.apache.org/jira/browse/HBASE-7957
             Project: HBase
          Issue Type: Bug
          Components: snapshots
            Reporter: Enis Soztutar
            Assignee: Enis Soztutar
             Fix For: 0.95.0, 0.98.0
         Attachments: hbase-7957_v1.patch

Ted noticed the following exception during TestSnapshotCloneIndependence#testOfflineSnapshotRegionOperationsIndependent()

{code}
2013-02-27 01:45:25,785 ERROR [MASTER_TABLE_OPERATIONS-juno.apache.org,46592,1361929424741-0] handler.CreateTableHandler(159): Error trying to create the table test-clone-test1361929508917
java.lang.IllegalStateException: Table test-clone-test1361929508917 is not locked!
	at org.apache.hadoop.hbase.master.TableLockManager$ZKTableLockManager$TableLockImpl.release(TableLockManager.java:257)
	at org.apache.hadoop.hbase.master.handler.CreateTableHandler.releaseTableLock(CreateTableHandler.java:233)
	at org.apache.hadoop.hbase.master.handler.CreateTableHandler.handleCreateTable(CreateTableHandler.java:226)
	at org.apache.hadoop.hbase.master.handler.CreateTableHandler.process(CreateTableHandler.java:153)
	at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:130)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
	at java.lang.Thread.run(Thread.java:722)
{code}

See https://builds.apache.org/job/HBase-TRUNK/3901/testReport/org.apache.hadoop.hbase.client/TestSnapshotCloneIndependence/testOfflineSnapshotRegionOperationsIndependent/. 

The root cause is that SnapshotManager does not invoke prepare() method for the created CloneSnapshotHandler. Prepare has been introduced in HBASE-7305, and acquires the table lock. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira