hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-7756) Strange code in ServerCallable#shouldRetry
Date Mon, 04 Feb 2013 17:22:13 GMT
nkeywal created HBASE-7756:

             Summary: Strange code in ServerCallable#shouldRetry
                 Key: HBASE-7756
                 URL: https://issues.apache.org/jira/browse/HBASE-7756
             Project: HBase
          Issue Type: Bug
          Components: Client
    Affects Versions: 0.96.0
            Reporter: nkeywal
            Assignee: nkeywal

This code is strange.
If you configure a different value for HBASE_CLIENT_OPERATION_TIMEOUT, you can have only one
socket timeout (whatever your setting for the socket timeout). If not, the first time we will
retry (again, whatever your setting and the real timeout).

  public void shouldRetry(Throwable throwable) throws IOException {
    if (this.callTimeout != HConstants.DEFAULT_HBASE_CLIENT_OPERATION_TIMEOUT)
      if (throwable instanceof SocketTimeoutException
          || (this.endTime - this.startTime > this.callTimeout)) {
        throw (SocketTimeoutException) new SocketTimeoutException(
            "Call to access row '" + Bytes.toString(row) + "' on table '"
                + Bytes.toString(tableName)
                + "' failed on socket timeout exception: " + throwable + " this.callTimeout="+this.callTimeout
+ " time= "+(this.endTime - this.startTime))
      } else {
        this.callTimeout = ((int) (this.endTime - this.startTime));

I don't get all the implications yet, but for sure it's too smart to be good, and, at least,
breaks my tests for HBASE-7590 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message