Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of enis.soz@gmail.com designates
 209.85.216.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CADcMMgF7RwO-5LPKdo9-auWy=oBeskMAThNa6GFDTLK7ZVC6NA@mail.gmail.com>
References: 
 <CA+RK=_BmV=vwws4VeDJVPt6hY7NKCDEafex3XTNam630pQRBbA@mail.gmail.com>
 <CADcMMgF7RwO-5LPKdo9-auWy=oBeskMAThNa6GFDTLK7ZVC6NA@mail.gmail.com>
From: =?UTF-8?Q?Enis_S=C3=B6ztutar?= <enis.soz@gmail.com>
Date: Mon, 7 Jan 2013 11:38:49 -0800
Message-ID: 
 <CAMUu0w9tS3D9Cam9tRx9K0igP8VDQXuQ+D_tK1dYxogAJksw1Q@mail.gmail.com>
Subject: Re: A couple of unit tests may be using a data dir of
 /tmp/hbase-${user}
To: "dev@hbase.apache.org" <dev@hbase.apache.org>
Content-Type: multipart/alternative; boundary=047d7b621ac8a37a0e04d2b7fbb1

--047d7b621ac8a37a0e04d2b7fbb1
Content-Type: text/plain; charset=UTF-8

I've also noticed this before, but though we fixed all instances in 96.
Instead of jenkins cleaning up, we should fix the tests themselves to not
use the /tmp directory. I guess we can use the ResourceChecker to detect
and fail those tests.

Enis


On Mon, Jan 7, 2013 at 11:32 AM, Stack <stack@duboce.net> wrote:

> On Mon, Jan 7, 2013 at 10:00 AM, Andrew Purtell <apurtell@apache.org>
> wrote:
>
> > There was a failure of TestLocalHBaseCluster in
> > https://builds.apache.org/job/PreCommit-HBASE-Build/3879 that I was able
> > to
> > reproduce locally, but what I think this means is a couple of tests are
> > using a data dir of /tmp/hbase-${user}.
> >
> > I bumped HFileV2.MAX_MINOR_VERSION to 3, then ran tests. Later I changed
> it
> > back to 2 after review advice from Ted. TestLocalHBaseCluster then
> started
> > failing because some HFiles with a version of 2.3 remained in the
> > filesystem under /tmp/hbase-${user} from earlier tests and could not be
> > read in by current tests. The precommit builds don't save the test logs
> so
> > I can't confirm if what is going on up on Jenkins is the same thing, but
> I
> > suspect so.
> >
> > I'm not sure if JUnit or Surefire can support a global post test action,
> > but I'll look into it. I want to test for the existence
> > of /tmp/hbase-${user} after a unit test has run and if so fail it to flag
> > it as an offender.
> >
>
>
> See
> ./hbase-common/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java
>
> Is it hdfs that is putting the files in /tmp?
>
> St.Ack
>

--047d7b621ac8a37a0e04d2b7fbb1--