hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-7602) TestFromClientSide.testPoolBehavior is incorrect
Date Thu, 17 Jan 2013 02:56:13 GMT
Lars Hofhansl created HBASE-7602:
------------------------------------

             Summary: TestFromClientSide.testPoolBehavior is incorrect
                 Key: HBASE-7602
                 URL: https://issues.apache.org/jira/browse/HBASE-7602
             Project: HBase
          Issue Type: Bug
            Reporter: Lars Hofhansl
            Assignee: Lars Hofhansl
             Fix For: 0.96.0, 0.94.5


The writer of this test misunderstood ThreadPoolExecutor.

The test adds Threads as tasks to a ThreadPoolExecutor and then calls join on the Thread objects.
But these are not the running threads, it work by pure accident, because Thread happens to
implement Runnable.

{code}
pool.submit(threads.get(0));
...
threads.get(0).join();
{code}

The join will always return immediately, because the thread never ran.
This should instead synchronize on the Future returned from submit instead, otherwise there
is no guarantee that the threads in the pool actually finished.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message