hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas Liochon <nkey...@gmail.com>
Subject Re: Where to place HTable.exists() tests?
Date Sat, 05 Jan 2013 17:01:43 GMT
Hi,

Look at the tests in the client package. Typically TestFromClientSide.
You may want to write some 'pure' unit test as well (i.e. small category).
Then you may want to create a specific class.
And I wouldn't be against a test class for HTable, especially is it can be
one that doesn't start a cluster.

In all cases, public boolean[] exists(Get[] gets) is not good imho.
You need this to be consistent with the API:
public Boolean[] exists(List<Get> gets)

Boolean and not boolean to manage the failures (null means failure for this
get).
List vs. array purely for consistency.

Cheers,

Nicolas


On Sat, Jan 5, 2013 at 5:30 PM, Jean-Marc Spaggiari <jean-marc@spaggiari.org
> wrote:

> public boolean[] exists(Get[] gets

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message