hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hiroshi Ikeda (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-7437) Improve CompactSelection
Date Wed, 26 Dec 2012 03:24:13 GMT
Hiroshi Ikeda created HBASE-7437:
------------------------------------

             Summary: Improve CompactSelection
                 Key: HBASE-7437
                 URL: https://issues.apache.org/jira/browse/HBASE-7437
             Project: HBase
          Issue Type: Improvement
          Components: Compaction
            Reporter: Hiroshi Ikeda
            Priority: Minor


1. Using AtomicLong makes CompactSelection simple and improve its performance.
2. There are unused fields and methods.
3. The fields should be private.
4. Assertion in the method finishRequest seems wrong:
{code}
  public void finishRequest() {
    if (isOffPeakCompaction) {
      long newValueToLog = -1;
      synchronized(compactionCountLock) {
        assert !isOffPeakCompaction : "Double-counting off-peak count for compaction";
{code}
The above assertion seems almost always false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message