hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jimmy Xiang <jxi...@cloudera.com>
Subject Re: thrift vs thrift2
Date Fri, 07 Dec 2012 22:20:10 GMT
Since thrift has many users while thrift2 doesn't, does it make more
sense to deprecate and remove thrift2 instead?
People are more used to the existing thrift interface.  Although it is
different from the java API, it seems to not have
any performance hit.

Thanks,
Jimmy

On Fri, Dec 7, 2012 at 2:01 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> Logged https://issues.apache.org/jira/browse/HBASE-7302 for this.
>
> On Fri, Dec 7, 2012 at 1:56 PM, Luke Lu <llu@apache.org> wrote:
>
>> The embeded HRegionThriftServer should be ported to thrift2 before we
>> deprecate thrift1. FB's (and potentially others) c++ client requires
>> HRegionThriftServer.
>>
>> __Luke
>>
>>
>> On Thu, Dec 6, 2012 at 7:21 PM, Andrew Purtell <apurtell@apache.org>
>> wrote:
>>
>> > +1 for deprecation. Will bring any users out of the woodwork who might
>> not
>> > see this discussion at least.
>> >
>> > On Friday, December 7, 2012, Jesse Yates wrote:
>> >
>> > > According to the thrift2 docs, it is the 'right' way to access HBase -
>> > the
>> > > thrift package is based on an older HBase interface that no longer
>> > exists.
>> > > Seems like a reasonable case for deprecation in the next release and
>> > > dropping it all together after.
>> > > -------------------
>> > > Jesse Yates
>> > > @jesse_yates
>> > > jyates.github.com
>> > >
>> > >
>> > > On Thu, Dec 6, 2012 at 4:48 PM, Stack <stack@duboce.net<javascript:;>>
>> > > wrote:
>> > >
>> > > > On Thu, Dec 6, 2012 at 3:24 PM, Jimmy Xiang <jxiang@cloudera.com
>> > <javascript:;>>
>> > > wrote:
>> > > >
>> > > > > Since 0.96 is a singularity, is it a time to deprecate thrift
>> > finally?
>> > > > >
>> > > > > Or we can use thrift2 by default, and keep thrift around more?
>> > > > >
>> > > > > What's the pros and cons to switch to thrift2?
>> > > > >
>> > > >
>> > > > Interesting notion.  Could move thrift2 to thrift altogether.  Would
>> > need
>> > > > to make sure thrift2 has all from thrift1.
>> > > > St.Ack
>> > > >
>> > >
>> >
>> >
>> > --
>> > Best regards,
>> >
>> >    - Andy
>> >
>> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
>> > (via Tom White)
>> >
>>

Mime
View raw message