hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lars hofhansl <lhofha...@yahoo.com>
Subject Re: Patches for the offline and online snapshots branches.
Date Sat, 29 Dec 2012 06:44:21 GMT
I think for feature branches we can be quite bit more liberal about applying patches.
Of course then the question is how to go about the eventual merge back into trunk.

If all patches in the branch were reviewed and +1'ed, the merge in theory would not need to
reviewed again.
Is what you are shooting for, Jon?

-- Lars

 From: Stack <stack@duboce.net>
To: HBase Dev List <dev@hbase.apache.org> 
Sent: Friday, December 28, 2012 10:21 PM
Subject: Re: Patches for the offline and online snapshots branches.
What can we review to help Jon?  What issue numbers?

On Thu, Dec 27, 2012 at 2:02 PM, Jonathan Hsieh <jon@cloudera.com> wrote:

> Hey all,
> I'm going to post one more rev for these and then plan on committing
> several patches onto the *snapshot branches* (not trunk) tomorrow.
> Each piece has gotten at least one review that seems positive (some
> don't have explict +1/ship it, some have +1 from non committers).
> Please let me know if there are any concerns with this course of
> action or if there are particular patches that I shouldn't commit yet
> because you are in the middle of a review.
> I have and will continue to file more follow-on jira's for problems
> found that will block trunk merge.  However, the overhead of keeping a
> stack of 4-5 patches on top is quite burdensome and it is difficult
> figure out if recent instability is due to environmental issues or due
> to recent changes in the code from reviews.  Having code down in this
> dev branch will help us improving the same code in one agreed upon
> place.
> Here's what I plan on committing to the offline snapshot branch:
> https://github.com/jyates/hbase/tree/snapshots aka
> https://github.com/jmhsieh/hbase/tree/hbase-6055
> HBASE-7208 - refactor to foreign exceptions
> In a new online snapshot branch:
> https://github.com/jmhsieh/hbase/tree/snapshots
> HBASE-7212 - globally barrier'ed procedure
> I'd like to commit these to the online branch as well but this will
> depend on how much changes in the latest rev.
> HBASE-6864 - online snapshot scaffolding
> HBASE-7321 - simple flush online snapshot
> At the moment the plan is to keep the online snapshots in separate
> branch -- there are plenty of issues with the offline snapshots that
> need to be resolved.
> Thanks,
> Jon.
> --
> // Jonathan Hsieh (shay)
> // Software Engineer, Cloudera
> // jon@cloudera.com
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message