Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of nkeywal@gmail.com designates
 209.85.217.169 as permitted sender)
MIME-Version: 1.0
From: Nicolas Liochon <nkeywal@gmail.com>
Date: Mon, 26 Nov 2012 19:21:11 +0100
Message-ID: 
 <CAPcDmSvJRtPsZhcUquqi=QUW_ifXyitZB=9CiJF9Xpm-AZgQeg@mail.gmail.com>
Subject: metrics / performance impact
To: dev@hbase.apache.org
Content-Type: multipart/alternative; boundary=f46d040715fdb764d304cf6a00bb

--f46d040715fdb764d304cf6a00bb
Content-Type: text/plain; charset=ISO-8859-1

Hi All,

I've got an issue related to metrics in HBase trunk.
I'm trying to create a table with 3000 regions on two regions servers, from
the shell.

It's ok on a standalone config.
It's ok on 0.94
It's not ok on trunk: it fails after around 1 hour.

If I remove all the code related to metrics in HRegion, the 3000 regions
are created in 3 minutes (twice faster than the 0.94).

When it fails the region server spends its time in "waitForWork", while the
master is in the tcp connection related code. It's a 1Gb network.

I haven't looked at the metric code itself.

So two questions :-)
1) Is there any work in progress on the metrics? I agree that my case makes
no sense in production, but it's useful for testing (and may be there are
production uses cases that are impacted as well.)
2) Is there any simple way to disable the metrics?

See below the changes I made to HRegion

Cheers,

Nicolas


--

index c70e9ab..6677e65 100644
---
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
+++
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
@@ -364,7 +364,7 @@ public class HRegion implements HeapSize { // ,
Writable{
   private HTableDescriptor htableDescriptor = null;
   private RegionSplitPolicy splitPolicy;

-  private final MetricsRegion metricsRegion;
+  private final MetricsRegion metricsRegion = null;

   /**
    * Should only be used for testing purposes
@@ -388,7 +388,7 @@ public class HRegion implements HeapSize { // ,
Writable{
     this.coprocessorHost = null;
     this.scannerReadPoints = new ConcurrentHashMap<RegionScanner, Long>();

-    this.metricsRegion = new MetricsRegion(new
MetricsRegionWrapperImpl(this));
+    //this.metricsRegion = new MetricsRegion(new
MetricsRegionWrapperImpl(this));
   }

   /**
@@ -451,7 +451,7 @@ public class HRegion implements HeapSize { // ,
Writable{
     this.regiondir = getRegionDir(this.tableDir, encodedNameStr);
     this.scannerReadPoints = new ConcurrentHashMap<RegionScanner, Long>();

-    this.metricsRegion = new MetricsRegion(new
MetricsRegionWrapperImpl(this));
+    //this.metricsRegion = new MetricsRegion(new
MetricsRegionWrapperImpl(this));

     /*
      * timestamp.slop provides a server-side constraint on the timestamp.
This
@@ -1024,7 +1024,7 @@ public class HRegion implements HeapSize { // ,
Writable{
         status.setStatus("Running coprocessor post-close hooks");
         this.coprocessorHost.postClose(abort);
       }
-      this.metricsRegion.close();
+      //this.metricsRegion.close();
       status.markComplete("Closed");
       LOG.info("Closed " + this);
       return result;
@@ -2331,11 +2331,11 @@ public class HRegion implements HeapSize { // ,
Writable{
       if (noOfPuts > 0) {
         // There were some Puts in the batch.
         double noOfMutations = noOfPuts + noOfDeletes;
-        this.metricsRegion.updatePut();
+        //this.metricsRegion.updatePut();
       }
       if (noOfDeletes > 0) {
         // There were some Deletes in the batch.
-        this.metricsRegion.updateDelete();
+        //this.metricsRegion.updateDelete();
       }
       if (!success) {
         for (int i = firstIndex; i < lastIndexExclusive; i++) {
@@ -4270,7 +4270,7 @@ public class HRegion implements HeapSize { // ,
Writable{

     // do after lock

-    this.metricsRegion.updateGet();
+    //this.metricsRegion.updateGet();

     return results;
   }
@@ -4657,7 +4657,7 @@ public class HRegion implements HeapSize { // ,
Writable{
       closeRegionOperation();
     }

-    this.metricsRegion.updateAppend();
+    //this.metricsRegion.updateAppend();


     if (flush) {
@@ -4795,7 +4795,7 @@ public class HRegion implements HeapSize { // ,
Writable{
         mvcc.completeMemstoreInsert(w);
       }
       closeRegionOperation();
-      this.metricsRegion.updateIncrement();
+      //this.metricsRegion.updateIncrement();
     }

     if (flush) {

--f46d040715fdb764d304cf6a00bb--