hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lars hofhansl <lhofha...@yahoo.com>
Subject Re: No protoc maven target?
Date Sun, 25 Nov 2012 06:36:32 GMT
Thanks Jon,

missed that README. Anyway, wasn't hard to figure out, just wondered why there wasn't a convenient
maven target.

While we're at the topic. I found that Put/Delecte and Increment still implement the Writable
interface and still provide write and readFields methods.


A feeble attempt to just remove them shows that they are still used here:
- IdentityTableReduce.java
- MultiPut.java
- HRegionServer.checkAndMutate


Are these still needed for M/R or in HBaseObjectWritable?

If we end up having to keep these writable implementations around it pretty much defeats the
wire compatibility goal.


-- Lars



________________________________
 From: Jonathan Hsieh <jon@cloudera.com>
To: dev@hbase.apache.org; lars hofhansl <lhofhansl@yahoo.com> 
Sent: Saturday, November 24, 2012 10:05 PM
Subject: Re: No protoc maven target?
 
This is true you have to run it, but
hbase-server/src/main/protobuf/README.txt which cut-and-paste instructions.

Would probably be better to add a build-protos shell script to dev-support/.

Jon.

On Sat, Nov 24, 2012 at 9:58 PM, lars hofhansl <lhofhansl@yahoo.com> wrote:

> I might just be a bit dense tonight, but do I really have to call protoc
> see myself (lookup the right options, figure out the right output path)
> when I change a .proto file?
> That's what I ended up doing, because there appears to be no maven target
> to regenerated the protobuf related files.
>
> -- Lars
>



-- 
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// jon@cloudera.com
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message