Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5317C9288 for ; Thu, 6 Sep 2012 20:29:00 +0000 (UTC) Received: (qmail 65678 invoked by uid 500); 6 Sep 2012 20:28:59 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 65629 invoked by uid 500); 6 Sep 2012 20:28:59 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 65619 invoked by uid 99); 6 Sep 2012 20:28:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2012 20:28:59 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of saint.ack@gmail.com designates 209.85.214.169 as permitted sender) Received: from [209.85.214.169] (HELO mail-ob0-f169.google.com) (209.85.214.169) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2012 20:28:54 +0000 Received: by obhx4 with SMTP id x4so4100477obh.14 for ; Thu, 06 Sep 2012 13:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=NLRKFPDKCjPpKR0zgdlEtMfpYBbGl3FWbk5o13N59M8=; b=bCVbl1mBEfFm26Az7e7wntTStbbRh7OR0o5IBeTwuQZZKif6Y1h8cg4oLWcFEJv5Zq LNeaGY7xXLXKuYmICx24esIxxUZXxc4VSFkizORx0nTbd3Y3ooxbNyhEe95gTNOTQ8zR reRJqRdsSnI9CFGMmFFOs+7yJMh4cxhGGBFHJF4ifmL/huDNRWAt2uMijlsESsNWDzUv foShjbIezK1FZ7TfZN5TAmnDU8vrgnPy+cT1Advyumg1u0kP0rj7QG36LDj5QNSXzLxB GFxOSUFTUhnaue8zhkNY/Trq4OWy48BtuUKCGhdfXf8vMprclLjN9Mo5yMN4r2Od/oHE OEHA== MIME-Version: 1.0 Received: by 10.60.30.170 with SMTP id t10mr3653867oeh.10.1346963314399; Thu, 06 Sep 2012 13:28:34 -0700 (PDT) Sender: saint.ack@gmail.com Received: by 10.76.25.201 with HTTP; Thu, 6 Sep 2012 13:28:34 -0700 (PDT) In-Reply-To: References: Date: Thu, 6 Sep 2012 13:28:34 -0700 X-Google-Sender-Auth: gYWETIw9yXCLTNAeNXk4neWM5Kg Message-ID: Subject: Re: Hbase Assignments in trunk. From: Stack To: dev@hbase.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Sep 6, 2012 at 3:16 AM, Jonathan Hsieh wrote: > On Wed, Sep 5, 2012 at 4:08 PM, Stack wrote: > >> On Wed, Sep 5, 2012 at 12:38 PM, Jonathan Hsieh wrote: ... >> We should post these invariants somewhere? In dev section of refguide? >> >> We should definitely put this in the javadoc. Maybe we should have a > dev-guide section of the ref-guide where some of these things are also > captured? > I added an invariants section to the developer pages. I used your wording of the zk data axiom above. (What other invariants do we have?) >> On a code craft point of view, failure behavior is buried deeply and could > be pulled out to the process methods of the handlers. In many cases, it > isn't easy to figure out why one behavior is chosen vs others. > Nod. > I'm also suggesting that we could avoid using ZK event callbacks like the > OPENING and OPENED zk transition and instead have the master would manage > those. We'd have an opening RS would tickle some other znode to show > progress. At least then RegionState would be closer to accurate, and the > HM would go through all state transitions. > Perhaps. I would look at any prospective design to see if I could see holes where master and regionserver might diverge in terms of what they think a particular region's state is at any one time (Up to this, they've done it via the znode proxy that one or the other purportedly owns outright at any time; there is even some facility for progressing in the face of missed callbacks though for sure we are now into a gray area). St.Ack