Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: unknown ~alla (nike.apache.org: encountered unrecognized
 mechanism during SPF processing of domain of mcorgan@hotpads.com)
MIME-Version: 1.0
In-Reply-To: 
 <CAB5sDN+Q3+J0x6bJ6jaSY9pp7y2BTwVvCx0v6yPA0dSY5qyUjQ@mail.gmail.com>
References: <04C9B397-ABF7-455F-911F-676D53B51CB4@gmail.com>
	<CAB5sDN+Q3+J0x6bJ6jaSY9pp7y2BTwVvCx0v6yPA0dSY5qyUjQ@mail.gmail.com>
Date: Sun, 1 Jul 2012 13:01:19 -0700
Message-ID: 
 <CAOKsKJUsjOhexT1zOucfgvR=uQJzeeaUWHdzgSAYX_dGd1gwzQ@mail.gmail.com>
Subject: Re: Test for KeyValue
From: Matt Corgan <mcorgan@hotpads.com>
To: dev@hbase.apache.org
Content-Type: multipart/alternative; boundary=14dae9cfcdb80cb6ec04c3ca2519

--14dae9cfcdb80cb6ec04c3ca2519
Content-Type: text/plain; charset=UTF-8

Hi guys - i agree it should be moved up and with Jesse's other comments as
well.  I have a patch in
HBASE-6234<https://issues.apache.org/jira/browse/HBASE-6234>that moves
the tests if one of the committers wants to take a look.  I
removed the @Category annotations following the example Jesse set when he
moved TestBytes to hbase-common.

We initially tried to move the tests at the same time as KeyValue, but
things got confusing with the tests so I split the jiras since I only
needed KeyValue moved for
HBASE-6226<https://issues.apache.org/jira/browse/HBASE-6226> (move
DataBlockEncoding interfaces to hbase-common).

btw - great work on the hbase-it module Enis.

Matt


On Sun, Jul 1, 2012 at 12:46 PM, Jesse Yates <jesse.k.yates@gmail.com>wrote:

> Yeah, looks like it should be moved up. @Matt Corgan - thoughts?
>
> My vision (perhaps arguable) is that all the "strict" unit tests can be
> moved to the module in which its primary code resides (so the TestKeyValue
> goes in the same module as KeyValue). For the moment, it means dropping the
> @Category and bringing up any test dependencies, which it looks like there
> are few if any external ones.
>
> We can debate if we want to include categories in common, since anything
> not in server (for the moment) should just be a unit test and everything in
> server can be either a unit or cluster test (so anything labeled with
> @Category(MediumTests.class or @Category(LargeTests.class).
>
> I'd argue the cluster tests are probably things that can be moved into
> hbase-it module that Enis just created (is creating?). His work in that
> area is also going to be really useful for abstracting of the minicluster
> so that it is actually feasible to have cluster tests that aren't full
> blown ITs. But that's a little ways off...
> -------------------
> Jesse Yates
> @jesse_yates
> jyates.github.com
>
>
> On Sun, Jul 1, 2012 at 12:32 PM, Lars George <lars.george@gmail.com>
> wrote:
>
> > Hi,
> >
> > For HBASE-6265 I noticed that in trunk the TestKeyValue is in
> > hbase-server, while KeyValue is in hbase-common now. Is that work left
> over?
> >
> > Lars
>

--14dae9cfcdb80cb6ec04c3ca2519--