hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Elliott Clark <ecl...@stumbleupon.com>
Subject Re: deprecating (old) metrics in favor of metrics2 framework
Date Fri, 13 Jul 2012 00:11:32 GMT
>From what I know about using guice it's best to only have on injector per
application.  So It's not really possible to only implement metrics with
guice.  There would need to be a medium amount of of work to pipe it all
the way from HMasterCommandLine/HRegionserverCommandLine alll the way to
metrics.  Probably something we should look into after the current patch
goes in so that we don't couple the two discussions too tightly.

On Thu, Jul 12, 2012 at 1:23 AM, Stack <stack@duboce.net> wrote:

> On Thu, Jul 12, 2012 at 4:07 AM, Elliott Clark <eclark@stumbleupon.com>
> wrote:
> > Yep.  This is pretty darn close to DI.  I would be willing to change the
> > patch that I just put up to use Guice if that's what people wanted.  I
> know
> > some of our classes could use some DI loving to help with testability.
> >
> So, you think we could Guice the metrics and then over time, Guice
> everything else Elliott?
> St.Ack

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message