hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stack <st...@duboce.net>
Subject Re: generate protocolbuffers sources reformatting change (trunk)
Date Wed, 18 Apr 2012 15:17:04 GMT
On Wed, Apr 18, 2012 at 1:47 AM, Ferdy Galema <ferdy.galema@kalooga.com> wrote:
> Hi,
> While working on an issue that requires a minor change (FYI: HBase-2214) to
> the protocolbuffers definition file, I noticed that regenerating the
> sources changes the formatting. I used the instructions in the README.txt
> file, nothing more or less. Am I missing something? Or are the current
> generated classes simply not in sync with the def file? Of course I could
> simply include all changes in the patch, but I thought I'd check with you
> first.

No effort has been made to make the pb generated files comply w/ our
convention nor do I see anyone interested in making that happen so I
wouldn't worry about it Ferdy.

Good on you,

View raw message