Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F238A9555 for ; Mon, 12 Mar 2012 17:58:58 +0000 (UTC) Received: (qmail 60670 invoked by uid 500); 12 Mar 2012 17:58:58 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 60626 invoked by uid 500); 12 Mar 2012 17:58:58 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 60618 invoked by uid 99); 12 Mar 2012 17:58:58 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2012 17:58:58 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of todd@cloudera.com designates 209.85.210.169 as permitted sender) Received: from [209.85.210.169] (HELO mail-iy0-f169.google.com) (209.85.210.169) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2012 17:58:50 +0000 Received: by iajr24 with SMTP id r24so9772245iaj.14 for ; Mon, 12 Mar 2012 10:58:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:x-gm-message-state; bh=/XuKTn2ItKhUuz7dJ2ZbRVG8OirZfLbT6Nnzv8PF2HQ=; b=XglI34nBIhDbz0ubYPiDueV3Gfx5rSsgZwbCB0oKw1ddZ8CeZcY9F3LSdI/CYL6kB1 w9e6Ow1uboo+J/f319S15kUjQIZTCGGZ7KWrE5xsSv0KLZaJdwpDBGqq103p9gnxkFGs bVd7zE58N9S+3RiAoIKVIVQnHGYHMVMdCjFAAYsvGhMe7IfbGRPZAl7q5UwN9GeMdEgP uUFSlkAc4Go9EMa4lDSPbLEzxaIz6mWPsjkxSUlHhG7vOIgPupbcQl4y6wo72GuI0MMt II6pAZ1X0zv/NUmx/VkBY9BEF+PZUuT8jyRsSLu6Ah3dW95ueKzd6RIMhP+9xc6LfLWE 69Xw== Received: by 10.42.72.130 with SMTP id o2mr18257248icj.8.1331575109212; Mon, 12 Mar 2012 10:58:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.208.70 with HTTP; Mon, 12 Mar 2012 10:58:09 -0700 (PDT) In-Reply-To: References: From: Todd Lipcon Date: Mon, 12 Mar 2012 10:58:09 -0700 Message-ID: Subject: Re: code review: HBASE-4608 HLog compression To: dev@hbase.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnqjkJKLiAPqBSz6ybceMbvRqDnxmmRcNR+9QWFbcut0DohUBJt1TZzpCJBk4ZC3vYY781B X-Virus-Checked: Checked by ClamAV on apache.org Hey Ted, Any chance you've been able to run YCSB on a small cluster for some performance results? Since this is a perf improvement, it would be great to have numbers. (I don't think it's a pre-req for commit, but definitely nice-to-have) -Todd On Mon, Mar 12, 2012 at 10:16 AM, Ted Yu wrote: > The latest patch version is 22. > > Please take a look. > > On Tue, Mar 6, 2012 at 5:22 PM, Ted Yu wrote: > >> Patch v19, the latest patch which addressed Todd's review, passed unit >> tests. >> >> FYI >> >> >> On Mon, Mar 5, 2012 at 3:50 PM, Ted Yu wrote: >> >>> Hi, >>> HBASE-4608 has gone through several iterations of code reviews. >>> Lars has marked 0.94 as release for HBASE-4608 HLog compression >>> >>> Please provide your review comments on https://reviews.apache.org/r/4185/ >>> >>> Thanks >>> >> >> -- Todd Lipcon Software Engineer, Cloudera