Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (nike.apache.org: domain of todd@cloudera.com designates
 209.85.210.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOcAC2EfB_WKCDJskTkTQphCwmdvqxMy3SzV==ihdYHAWGSHOQ@mail.gmail.com>
References: <000901cd07eb$0fd1d050$2f7570f0$%ch@huawei.com>
 <1332432010.36053.YahooMailNeo@web121703.mail.ne1.yahoo.com>
 <CAOcAC2EfB_WKCDJskTkTQphCwmdvqxMy3SzV==ihdYHAWGSHOQ@mail.gmail.com>
From: Todd Lipcon <todd@cloudera.com>
Date: Thu, 22 Mar 2012 11:06:13 -0700
Message-ID: 
 <CADY20s4ddsZugRq5NG_6H-bLvG=YZPtb4wpTPAp_i76ojALw8A@mail.gmail.com>
Subject: Re: HBASE Code format
To: dev@hbase.apache.org
Cc: lars hofhansl <lhofhansl@yahoo.com>,
 "lakshman.ch@huawei.com" <lakshman.ch@huawei.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

+1 for 100 chars. I think unlimited gets messy.

On Thu, Mar 22, 2012 at 9:50 AM, Dave Wang <dsw@cloudera.com> wrote:
> +1 on Lars's comment.
>
> On Thu, Mar 22, 2012 at 9:00 AM, lars hofhansl <lhofhansl@yahoo.com> wrot=
e:
>
>> Put me in the I-couldn't-care-less camp :) 80, 100, 120, or even no limi=
t
>> is fine with me.
>> Would personally prefer no limit. Instead leave it up to the good taste =
of
>> the contributors and us committers to format the code in the most readab=
le
>> way.
>>
>>
>> -- Lars
>>
>>
>> ________________________________
>> =A0From: Laxman <lakshman.ch@huawei.com>
>> To: dev@hbase.apache.org
>> Sent: Wednesday, March 21, 2012 10:17 PM
>> Subject: HBASE Code format
>>
>> Hi Devs,
>>
>> How about raising the "max line width" from 80 (to 100 or 120)?
>> IMO, 80 characters length is too low & it makes the code bit ugly.
>>
>> Example:
>> =A0 =A0 long timstamp =3D conf.getLong(TIMESTAMP_CONF_KEY,
>> System.currentTimeMillis());
>>
>> Above code snippet after formatting, it turned to
>>
>> =A0 =A0 long timstamp =3D conf
>> =A0 =A0 =A0 =A0 .getLong(TIMESTAMP_CONF_KEY, System.currentTimeMillis())=
;
>>
>> Please respond with your opinion considering the following points.
>>
>> - Sun Java coding standards drafted in 1999
>> - Terminals(Monitors) we are using now are very wider and 80 characters =
is
>> not a valid limit anymore.
>> - As per Ted, Google raised this limit
>> [https://issues.apache.org/jira/browse/HBASE-5564]
>>
>> Note: We don't need to reformat entire codebase. My proposal is to apply
>> these standards to new code getting commited.
>>
>> --
>> Regards,
>> Laxman
>>


--=20
Todd Lipcon
Software Engineer, Cloudera