hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug Meil <doug.m...@explorysmedical.com>
Subject Re: HBASE Code format
Date Thu, 22 Mar 2012 14:09:52 GMT

+1.  Assuming that this passes, I'll update the RefGuide in the
Development chapter.





On 3/22/12 2:08 AM, "Anoop Sam John" <anoopsj@huawei.com> wrote:

>+1 for 100 chars
>________________________________________
>From: Li Pi [li@idle.li]
>Sent: Thursday, March 22, 2012 10:55 AM
>To: dev@hbase.apache.org; V v lakshmana kumar chekka
>Subject: Re: HBASE Code format
>
>+1.
>
>On Wed, Mar 21, 2012 at 10:17 PM, Laxman <lakshman.ch@huawei.com> wrote:
>
>> Hi Devs,
>>
>> How about raising the "max line width" from 80 (to 100 or 120)?
>> IMO, 80 characters length is too low & it makes the code bit ugly.
>>
>> Example:
>>    long timstamp = conf.getLong(TIMESTAMP_CONF_KEY,
>> System.currentTimeMillis());
>>
>> Above code snippet after formatting, it turned to
>>
>>    long timstamp = conf
>>        .getLong(TIMESTAMP_CONF_KEY, System.currentTimeMillis());
>>
>> Please respond with your opinion considering the following points.
>>
>> - Sun Java coding standards drafted in 1999
>> - Terminals(Monitors) we are using now are very wider and 80 characters
>>is
>> not a valid limit anymore.
>> - As per Ted, Google raised this limit
>> [https://issues.apache.org/jira/browse/HBASE-5564]
>>
>> Note: We don't need to reformat entire codebase. My proposal is to apply
>> these standards to new code getting commited.
>>
>> --
>> Regards,
>> Laxman
>>
>>
>>
>



Mime
View raw message