hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harsh J <ha...@cloudera.com>
Subject Re: need a little help with a patch submission
Date Mon, 12 Mar 2012 19:45:22 GMT
Hi,

Use {{git diff --no-prefix}} when generating your patches, as the QA
bot assumes its an SVN patch and thats how you can make it compatible.

But please file a JIRA to add such a note to the book where it
recommends "git diff".
(With a --no-prefix doc patch if you please ;))

On Tue, Mar 13, 2012 at 1:09 AM, Sujee Maniyam <sujee@sujee.net> wrote:
> https://issues.apache.org/jira/browse/HBASE-5198?focusedCommentId=13226635&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13226635
>
> I don't quite understand why the patching failed.
>
> I am relatively a newbie and following this :
> http://hbase.apache.org/book/submitting.patches.html
>
> Help appreciated.
>
> thanks very much
> Sujee
>
>
> ----output from :
> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>
> patching file b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
> Hunk #1 FAILED at 466.
> 1 out of 1 hunk FAILED -- saving rejects to file
> b/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java.rej
> PATCH APPLICATION FAILED
>
>
> -1 overall.  Here are the results of testing the latest attachment
>  http://issues.apache.org/jira/secure/attachment/12517806/PerformanceEvaluation_HBASE_5198.patch
>  against trunk revision .
>
>    +1 @author.  The patch does not contain any @author tags.
>
>    +1 tests included.  The patch appears to include 3 new or modified tests.
>
>    -1 patch.  The patch command could not apply the patch.
>
> Console output:
> https://builds.apache.org/job/PreCommit-HBASE-Build/1152//console
>
> This message is automatically generated.
> -------
>
> http://sujee.net



-- 
Harsh J

Mime
View raw message