Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A325298FB for ; Fri, 3 Feb 2012 05:08:46 +0000 (UTC) Received: (qmail 93194 invoked by uid 500); 3 Feb 2012 05:08:42 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 92748 invoked by uid 500); 3 Feb 2012 05:08:33 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 92736 invoked by uid 99); 3 Feb 2012 05:08:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Feb 2012 05:08:30 +0000 X-ASF-Spam-Status: No, hits=0.3 required=5.0 tests=FRT_ADOBE2,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of saint.ack@gmail.com designates 209.85.214.169 as permitted sender) Received: from [209.85.214.169] (HELO mail-tul01m020-f169.google.com) (209.85.214.169) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Feb 2012 05:08:22 +0000 Received: by obbta7 with SMTP id ta7so5158019obb.14 for ; Thu, 02 Feb 2012 21:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=jYGpSySQe8cF6QwXGRXWRahID4ao7jw5rozkk71ZTUM=; b=PoHlBs9vps/5y0dsqKQBIauoGphl1sGSByETre9gC8ngprA5rDtfjKYiNq+q7CzyuO LL3eZyTDJgtBw9JBbtcSQx5mT8DLCK/oZLGvcyqS561QGsnvhJVTvbAP600PmN5/fuFU +wuGM2oJXdgTkFJ9oE6YtBqbboGj8PR4w70rE= MIME-Version: 1.0 Received: by 10.182.169.4 with SMTP id aa4mr830900obc.62.1328245681322; Thu, 02 Feb 2012 21:08:01 -0800 (PST) Sender: saint.ack@gmail.com Received: by 10.182.7.101 with HTTP; Thu, 2 Feb 2012 21:08:01 -0800 (PST) In-Reply-To: <3087C3EE109D634A82116DB24F8B48452A22FC@nambx09.corp.adobe.com> References: <3087C3EE109D634A82116DB24F8B48452A22FC@nambx09.corp.adobe.com> Date: Thu, 2 Feb 2012 21:08:01 -0800 X-Google-Sender-Auth: xIGOiFnd6_1M7EECM5nuO52hlWs Message-ID: Subject: Re: OBOB in HMerge? From: Stack To: dev@hbase.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Feb 2, 2012 at 3:05 PM, Sandy Pratt wrote: > I've been reading through this a bit lately as I work on a merge tool for our tables, and it looks like there's an off by one bug in the OfflineMerger constructor in util.HMerge: > Agree > I get the impression this class doesn't get used much, but just thought I'd point it out. > Any chance of a JIRA and a patch Sandy? (You are right that stuff doesn't get exercised much -- we need to finish off the online merge scripts -- are you working on somethink like this?) St.Ack