hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: Mocking classes for unit tests Was: asynchbase-1.2.0-rc1 is available for download
Date Wed, 22 Feb 2012 20:33:43 GMT
I logged https://issues.apache.org/jira/browse/HBASE-5456

I think we should make "for test only" methods private in the above JIRA.

Feel free to comment on the JIRA or in this thread.

Thanks

On Wed, Feb 22, 2012 at 12:24 PM, tsuna <tsunanet@gmail.com> wrote:

> On Wed, Feb 22, 2012 at 9:23 AM, Ted Yu <yuzhihong@gmail.com> wrote:
> > Benoit's comment is directly related to our practice, especially when we
> > add new methods which are only called by unit tests.
>
> I didn't dare to say it, but now that you do… :P
>
> HBase exposes a TON of implementation details in public APIs.  Makes
> things harder to refactor because you don't know if anyone out there
> is relying on this method or extending that class.
>
> Mocking out things that are hidden is certainly a bit harder than
> calling into a public API javadoced as "for test only", but if it
> keeps the APIs clean, then I think it's worthwhile.
>
> --
> Benoit "tsuna" Sigoure
> Software Engineer @ www.StumbleUpon.com
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message