hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cosmin Lehene <cleh...@adobe.com>
Subject Re: Addition of an extra method to HRegionServer consensus
Date Thu, 12 Jan 2012 09:41:09 GMT

Semantically (at least to me :)) it makes sense to have a flushAllRegions
method. The flushAllRegions disguised in flushRegions(null) would be
hidden logic. One would expect a NPE or nothing to happen if the
parameters is null.More, if the parameter comes null unintentionally, we
wouldn't like to flush everything.


On 1/11/12 8:46 PM, "Akash Ashok" <thehellmaker@gmail.com> wrote:

>Hi All,
>There's a discussion going on HBase-4224 about adding a new method to the
>Just to give a brief.  The patch to HBase-4224 has 2 methods in
>1. flushRegions(List<HRegionInfo> regions)  - which flushes a list of
>2. flushAllRegions() - flushes all the regions of the region server
>The decision to be made is whether to have flushAllRegions as a separate
>method or make flushRegions itself flush all the regions when the
>List<HregionInfo> parameter passed is null.
>Could we have the opinion of the community on this please ?
>Akash A

View raw message