Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69F31709A for ; Tue, 29 Nov 2011 06:31:05 +0000 (UTC) Received: (qmail 29070 invoked by uid 500); 29 Nov 2011 06:31:03 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 29035 invoked by uid 500); 29 Nov 2011 06:31:02 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 29027 invoked by uid 99); 29 Nov 2011 06:31:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Nov 2011 06:31:00 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of saint.ack@gmail.com designates 209.85.215.41 as permitted sender) Received: from [209.85.215.41] (HELO mail-lpp01m010-f41.google.com) (209.85.215.41) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Nov 2011 06:30:53 +0000 Received: by lamb11 with SMTP id b11so1150978lam.14 for ; Mon, 28 Nov 2011 22:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=149rqZB8nDnhIOL9Fj76uJe4OsQ1M4XQ3IiY4FSbQNw=; b=szy8doohWmsoB4KWPW4JYoqBlsuA6cstUNRtfpd8snLdVPfBsm7zGgNWmp9OVuwYFr qUQntm/dJIEjw+Bt8Elgnul+Ah7OgkLzrtLe49idlMROPiIBSXTI5/1ntlzu7551O8qr m8PZvKmy69xdgc7KPfw4gWDJmFGjMFEcc2EEg= MIME-Version: 1.0 Received: by 10.152.135.179 with SMTP id pt19mr30183588lab.47.1322548232769; Mon, 28 Nov 2011 22:30:32 -0800 (PST) Sender: saint.ack@gmail.com Received: by 10.152.10.226 with HTTP; Mon, 28 Nov 2011 22:30:32 -0800 (PST) In-Reply-To: References: Date: Mon, 28 Nov 2011 22:30:32 -0800 X-Google-Sender-Auth: 3rHTqIeiB2ob-rw-7i_L3nM3k1M Message-ID: Subject: Re: unit tests From: Stack To: dev@hbase.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Mon, Nov 28, 2011 at 12:29 PM, N Keywal wrote: > Hi, > > The surefire modification seems to work well, so we can move to the final > step. > Please find below the last proposition for the test. The behavior describ= ed > can be activated with: > =A0- a commit of hbase-4847 > =A0- a modification of the jenkins config to run mvn verify vs. mvn tests= . > > The main points are: > =A0- should we run small & medium tests only by default on a developer > machine =3D> here answer is yes > =A0- should we run all tests on the central build =3D> here answer is yes > =A0- should we stop when a small test fails =3D> here answer is yes > =A0- should we stop when a medium test fails =3D> here answer is yes > > > Also, I just had a discussion with Jesse, who think we should keep/have t= he > notion of integration test. If retained, the points above must be impacte= d > to take this into account. > All sounds good to me. I'm up for committing hbase-4847, amending jenkins build, and adding the below as doc into the hbase book. I'll wait a day or two more in case more input. One thing I don't follow is 'keep/have the notion of integration test'. How would that amend the above? Is it that verify has been coopted to "...execute small tests in a single JVM then medium tests in a separate JVM for each test, then large tests in a separate JVM as well."? And we'd need to undo this so verify was still available to do Integration tests? (Integration tests are tests that are named IntegrationTest* and run for a long time)? Good stuff lads, St.Ack