hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Purtell <apurt...@apache.org>
Subject Re: unit tests improvement
Date Thu, 03 Nov 2011 19:33:07 GMT
> From: Ted Yu <yuzhihong@gmail.com>

> I think all patches for TRUNK (0.92 included in the near future since
> they're quite close) should go through HadoopQA, i.e. patch testing.
> 
> The rationale is that contributor may not have hardware + OS (Ubuntu)
> combination that Jenkins uses.
> Certain timing related issues would be exposed on Jenkins, as previous
> incidents have shown.


+1

Jenkins aka Hudson is a bastard. He often turns up timing issues impossible to reproduce locally.
 
Best regards,


   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)


----- Original Message -----
> From: Ted Yu <yuzhihong@gmail.com>
> To: dev@hbase.apache.org
> Cc: 
> Sent: Thursday, November 3, 2011 10:04 AM
> Subject: Re: unit tests improvement
> 
> With help from Giri, we have patch testing for TRUNK.
> I think all patches for TRUNK (0.92 included in the near future since
> they're quite close) should go through HadoopQA, i.e. patch testing.
> 
> The rationale is that contributor may not have hardware + OS (Ubuntu)
> combination that Jenkins uses.
> Certain timing related issues would be exposed on Jenkins, as previous
> incidents have shown.
> 
> For patches targeting 0.90.x, we rely on contributor/committer to run test
> suite.
> 
> Cheers
> 
> On Thu, Nov 3, 2011 at 9:53 AM, N Keywal <nkeywal@gmail.com> wrote:
> 
>>  > > 2) HBASE-4737 is for the split; as discussed two weeks ago. There 
> is a
>>  > > split proposal. I will apply this split this week-end or monday, 
> don't
>>  > > hesitate to provide a feedback before (or after if necessary :-). 
> I
>>  > tested
>>  > > the parallelization within surefire for the small tests, it seems 
> to
>>  work
>>  > > quite well.
>>  > >
>>  > > Don't forget that the idea is to run only small & medium 
> on the
>>  developer
>>  > > machine by default. This will make the sub-tests-suite runs under 
> 30
>>  > > minutes, but the selection is important if we don't want to 
> kill the
>>  > > pre-patch machine with defects that could have been detected 
> before.
>>  > >
>>  >
>>  > You thinking patch-build should not run the full suite?
>>  >
>>  >
>>  I was thinking about the hbase-book, chapter "13.7 submitting 
> patch". Today
>>  it says; " Make sure unit tests pass locally before submitting the 
> patch.".
>>  It could become something as: "Make sure unit tests pass locally 
> before
>>  submitting the patch. For large or risky patches, run as well the
>>  integration/large tests suite before submitting".
>> 
>

Mime
View raw message