hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Purtell <apurt...@apache.org>
Subject Re: Commit Log format
Date Tue, 01 Nov 2011 22:42:12 GMT
> From: Stack <stack@duboce.net>

> I used to be of the school where commit message was fat describing all
> that changed but seems like fashion now is to have that up in the
> JIRA.  I kinda liked having the big commit messages; made the commit
> log more interesting reading.


Having the below at the top of the message all on one line facilitates grepping:

   HBASE-xxx <title>
 
Beyond that, I've perused the commit log on 0.89-fb and certainly wouldn't mind if similar
Summary and Test Plan conventions made it upstream. I spend a lot of time browsing commit
logs these days, having that information can put the diff in better context.

> We should just auto-generate it.  JIRA can do it for us.  Its a PITA
> trying to keep it up and its always going to have holes in it.  I
> suggest we move to auto-generated in TRUNK.


+1

Best regards,


   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)


----- Original Message -----
> From: Stack <stack@duboce.net>
> To: dev@hbase.apache.org
> Cc: 
> Sent: Tuesday, November 1, 2011 3:34 PM
> Subject: Re: Commit Log format
> 
> On Tue, Nov 1, 2011 at 3:20 PM, Nicolas Spiegelberg <nspiegelberg@fb.com> 
> wrote:
>>  Committer questions.  I accidentally checked in some changes to HBase
>>  trunk with the Phabricator checkin format.  I used svn propedit to correct
>>  the log comments, so everything should look correct.  However, this raised
>>  a couple questions about committing code to HBase.
>> 
>>  1.  I know the required format is "HBASE-##### Title".  Is 
> anything else
>>  allowed?  Would including Phabricator comment mess up existing scripts?
>>  I'm assuming people are running something just slightly more 
> complicated
>>  than "svn log|grep ^HBASE".
> 
> IIRC, we just picked up the hadoop convention.
> 
> I used to be of the school where commit message was fat describing all
> that changed but seems like fashion now is to have that up in the
> JIRA.  I kinda liked having the big commit messages; made the commit
> log more interesting reading.
> 
>>   2.  Is there a reason why our CHANGES.txt isn't automated?  This is
>>  kinda a pain to keep updated, especially for something that we could just
>>  run "svn log|grep ^HBASE" on right before release.  I know that 
> HIVE
>>  changelog is auto-generated.  I'm assuming most other projects do this 
> as
>>  well.
>> 
> 
> We should just auto-generate it.  JIRA can do it for us.  Its a PITA
> trying to keep it up and its always going to have holes in it.  I
> suggest we move to auto-generated in TRUNK.
> 
> St.Ack
>

Mime
View raw message