Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of yuzhihong@gmail.com
 designates 74.125.82.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CADY20s5rsbbk51khYi=uDc=qtHuoFUpFgQJBneGKDzTdbp5VDg@mail.gmail.com>
References: 
 <CALte62wJNG1yAmhzDt7fqdCUZDwmU8hqsY1mEi3EFmkEtfabbQ@mail.gmail.com>
	<CADY20s5rsbbk51khYi=uDc=qtHuoFUpFgQJBneGKDzTdbp5VDg@mail.gmail.com>
Date: Thu, 20 Oct 2011 15:11:57 -0700
Message-ID: 
 <CALte62yan0_BeLWaLVh0YbLJNYbjAPLn=sonYvkDb4ZBRU4kWg@mail.gmail.com>
Subject: Re: suggestion for smoother code review process
From: Ted Yu <yuzhihong@gmail.com>
To: dev@hbase.apache.org
Content-Type: multipart/alternative; boundary=0016e64c0b68b07cd304afc23e06

--0016e64c0b68b07cd304afc23e06
Content-Type: text/plain; charset=ISO-8859-1

I think the easiest improvement is to strip the list of files from
reviewboard feedback.

I would wait for a while to see if any volunteer comes up for the above task
:-)

I am not sure about phabricator which requires an account.
I remember seeing phabricator feedback in JIRA. The format is different.

Cheers

On Thu, Oct 20, 2011 at 3:05 PM, Todd Lipcon <todd@cloudera.com> wrote:

> Hey Ted,
>
> I agree the formatting of the reviewboard comments back onto JIRA
> could be improved. I wrote the original script that does it - it's
> some nasty procmail and python.
>
> It sounds like the FB folks are working on getting phabricator up -
> maybe it will have better JIRA integration?
>
> Let me know if you have some time to spend on improving the
> python/procmail setup with RB. I can connect you with the right infra
> people to make the change.
>
> -Todd
>
> On Thu, Oct 20, 2011 at 3:03 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> > Hi,
> > We have been using review board for a while to conduct code review.
> > One aspect I don't like the integration is that every round of review
> would
> > result in the summary and list of files (both of which could be long) to
> be
> > reposted to JIRA.
> > For a large project, such as HBASE-2856 or HBASE-3777, it is impossible
> > (without exaggeration) for a developer who didn't closely follow the
> > development to understand what was going on.
> >
> > I want to share what I have been doing recently (by not commenting on
> review
> > board, if possible):
> > I would quote the snippet of code in the patch and make my comment
> >
> > I think the person asking for review can post the url for review board
> > request on the JIRA. By not filling Bugs field, we don't incur extra
> > housekeeping that I mentioned earlier.
> > If the Groups and People fields are filled properly, there is no risk of
> > losing review request. In the worst case, one sentence on the JIRA can
> > remind related people to look at the patch again.
> >
> > Note the above is just personally advice. Please don't interpret it as
> rule
> > or anything like that.
> >
> > Cheers
> >
>
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera
>

--0016e64c0b68b07cd304afc23e06--