Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of yuzhihong@gmail.com
 designates 74.125.82.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1319148414.83086.YahooMailNeo@web65501.mail.ac4.yahoo.com>
References: 
 <CALte62wJNG1yAmhzDt7fqdCUZDwmU8hqsY1mEi3EFmkEtfabbQ@mail.gmail.com>
	<1319148414.83086.YahooMailNeo@web65501.mail.ac4.yahoo.com>
Date: Thu, 20 Oct 2011 15:08:42 -0700
Message-ID: 
 <CALte62wZz2CeZZicKMRO2fBgN5pxmK2-_ZueG7HcnOmZ9eWvfg@mail.gmail.com>
Subject: Re: suggestion for smoother code review process
From: Ted Yu <yuzhihong@gmail.com>
To: dev@hbase.apache.org, Andrew Purtell <apurtell@apache.org>
Content-Type: multipart/alternative; boundary=0016363ba0d42142ad04afc233fb

--0016363ba0d42142ad04afc233fb
Content-Type: text/plain; charset=ISO-8859-1

That's why I would get nervous if I step away from computer for an hour :-)

On Thu, Oct 20, 2011 at 3:06 PM, Andrew Purtell <apurtell@apache.org> wrote:

> +1
>
> dev@ is not really possible to follow anymore, unless full time on HBase.
>
>
> Best regards,
>
>
>       - Andy
>
>
>
>
> >________________________________
> >From: Ted Yu <yuzhihong@gmail.com>
> >To: dev@hbase.apache.org
> >Sent: Thursday, October 20, 2011 3:03 PM
> >Subject: suggestion for smoother code review process
> >
> >Hi,
> >We have been using review board for a while to conduct code review.
> >One aspect I don't like the integration is that every round of review
> would
> >result in the summary and list of files (both of which could be long) to
> be
> >reposted to JIRA.
> >For a large project, such as HBASE-2856 or HBASE-3777, it is impossible
> >(without exaggeration) for a developer who didn't closely follow the
> >development to understand what was going on.
> >
> >I want to share what I have been doing recently (by not commenting on
> review
> >board, if possible):
> >I would quote the snippet of code in the patch and make my comment
> >
> >I think the person asking for review can post the url for review board
> >request on the JIRA. By not filling Bugs field, we don't incur extra
> >housekeeping that I mentioned earlier.
> >If the Groups and People fields are filled properly, there is no risk of
> >losing review request. In the worst case, one sentence on the JIRA can
> >remind related people to look at the patch again.
> >
> >Note the above is just personally advice. Please don't interpret it as
> rule
> >or anything like that.
> >
> >Cheers
> >
> >
> >
>

--0016363ba0d42142ad04afc233fb--