Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of yuzhihong@gmail.com
 designates 74.125.82.169 as permitted sender)
MIME-Version: 1.0
Date: Thu, 20 Oct 2011 15:03:01 -0700
Message-ID: 
 <CALte62wJNG1yAmhzDt7fqdCUZDwmU8hqsY1mEi3EFmkEtfabbQ@mail.gmail.com>
Subject: suggestion for smoother code review process
From: Ted Yu <yuzhihong@gmail.com>
To: dev@hbase.apache.org
Content-Type: multipart/alternative; boundary=0016364d21b3c256c704afc21e9e

--0016364d21b3c256c704afc21e9e
Content-Type: text/plain; charset=ISO-8859-1

Hi,
We have been using review board for a while to conduct code review.
One aspect I don't like the integration is that every round of review would
result in the summary and list of files (both of which could be long) to be
reposted to JIRA.
For a large project, such as HBASE-2856 or HBASE-3777, it is impossible
(without exaggeration) for a developer who didn't closely follow the
development to understand what was going on.

I want to share what I have been doing recently (by not commenting on review
board, if possible):
I would quote the snippet of code in the patch and make my comment

I think the person asking for review can post the url for review board
request on the JIRA. By not filling Bugs field, we don't incur extra
housekeeping that I mentioned earlier.
If the Groups and People fields are filled properly, there is no risk of
losing review request. In the worst case, one sentence on the JIRA can
remind related people to look at the patch again.

Note the above is just personally advice. Please don't interpret it as rule
or anything like that.

Cheers

--0016364d21b3c256c704afc21e9e--