hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Helmling <ghelml...@gmail.com>
Subject Re: TestHLog hanging in trunk
Date Wed, 05 Oct 2011 18:55:35 GMT
Somehow TestHLog was never actually shutting down the mini-cluster?

The following change lets the test exit successfully:

diff --git
a/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
b/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
index 663b318..13f821c 100644
--- a/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
+++ b/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
@@ -54,6 +54,7 @@ import
org.apache.hadoop.hdfs.server.namenode.LeaseManager;
 import org.apache.hadoop.io.SequenceFile;
 import org.apache.log4j.Level;
 import org.junit.After;
+import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
@@ -120,6 +121,11 @@ public class TestHLog  {
     oldLogDir = new Path(hbaseDir, ".oldlogs");
     dir = new Path(hbaseDir, getName());
   }
+  @AfterClass
+  public static void tearDownAfterClass() throws Exception {
+    TEST_UTIL.shutdownMiniCluster();
+  }
+
   private static String getName() {
     // TODO Auto-generated method stub
     return "TestHLog";


On Wed, Oct 5, 2011 at 11:23 AM, Gary Helmling <ghelmling@gmail.com> wrote:

> I've noticed that TestHLog is currently hanging in trunk (haven't checked
> other branches).  Oddly the tests actually complete, but then the test hangs
> in teardown.
>
> Seems to be something in the server shutdown hooks.  git bisect tracks down
> the hang to this commit:
>
> commit 9c195c7ef350a932a9901a2069b96694d202c675
> Author: Michael Stack <stack@apache.org>
> Date:   Fri Sep 30 21:45:20 2011 +0000
>
>     HBASE-4209 The HBase hbase-daemon.sh SIGKILLs master when stopping it
>
>     git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@117784913f79535-47bb-0310-9956-ffa450edef68
>
>
> Anyone else noticed this on TestHLog or other tests?  I think it may be
> behind some of our odd test cleanup issues up in Jenkins.
>
> --gh
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message