Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of saint.ack@gmail.com
 designates 209.85.216.176 as permitted sender)
MIME-Version: 1.0
Sender: saint.ack@gmail.com
In-Reply-To: 
 <CALte62xzfdQDe+QQDjGSnYG3t=5Uzek2PGp_biOjKqUPRmMZRA@mail.gmail.com>
References: 
 <CALte62xzfdQDe+QQDjGSnYG3t=5Uzek2PGp_biOjKqUPRmMZRA@mail.gmail.com>
Date: Sat, 10 Sep 2011 14:33:07 -0700
Message-ID: 
 <CADcMMgHJBhvodZJbRy0SCm02uiWVF=0Qy8JTrJ67xBPVrepvtw@mail.gmail.com>
Subject: Re: HBASE-4358
From: Stack <stack@duboce.net>
To: dev@hbase.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Its as though we should do all the mods in a tmp dir and then if all
go through, only then do fs.rename moving the new schema into place.

St.Ack

On Fri, Sep 9, 2011 at 7:25 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> I ran unit tests for HBASE-4358 patch 3 and they passed.
>
> The only issue remaining is in TableMultiFamilyHandler.java
> =A0@Override
> =A0protected void updateTableDescriptor(HTableDescriptor desc)
> =A0 =A0throws IOException {
> =A0 =A0// just ask all of the sub-operations to update the descriptor
> =A0 =A0for (TableFamilyHandler op : operations) {
> =A0 =A0 =A0op.updateTableDescriptor(desc);
> =A0 =A0}
> =A0}
> where we don't have ACID guarantee that either all modifications go throu=
gh
> or none of the modifications go through.
>
> If the above is Okay, I can add javadoc for the above at time of commit.
>
> If anyone thinks this is not good, please comment on ways of supporting A=
CID
> guarantee.
>
> Thanks
>