Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3560C774E for ; Sun, 28 Aug 2011 01:11:48 +0000 (UTC) Received: (qmail 1896 invoked by uid 500); 28 Aug 2011 01:11:47 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 1701 invoked by uid 500); 28 Aug 2011 01:11:47 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 1693 invoked by uid 99); 28 Aug 2011 01:11:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Aug 2011 01:11:46 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of yuzhihong@gmail.com designates 209.85.218.41 as permitted sender) Received: from [209.85.218.41] (HELO mail-yi0-f41.google.com) (209.85.218.41) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Aug 2011 01:11:41 +0000 Received: by yib2 with SMTP id 2so3104424yib.14 for ; Sat, 27 Aug 2011 18:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=EGunuf8EyWog6XYvA3MzpLYID9NrHLAlrLBnCEULU/M=; b=iL9yMMCKuMz9hEg74/w549mMRwPZ2RPQFzZrwlIrfXvJu/mxiGk0slNkp2txvJsX7g C7bwUFnscdl8TVXlHv09e0l6sstM/jwePyrHfEFTxPg79cmrF+rfWl+4+PEIi00qH0LL CGqf+wC6RzdQAf3BbaeYt2p4UjFEA6cyvlmDY= MIME-Version: 1.0 Received: by 10.42.176.72 with SMTP id bd8mr1481186icb.190.1314493881081; Sat, 27 Aug 2011 18:11:21 -0700 (PDT) Received: by 10.42.142.10 with HTTP; Sat, 27 Aug 2011 18:11:21 -0700 (PDT) In-Reply-To: References: Date: Sat, 27 Aug 2011 18:11:21 -0700 Message-ID: Subject: Re: removing trailing whitespace in patch From: Ted Yu To: dev@hbase.apache.org Cc: Doug Meil Content-Type: multipart/alternative; boundary=90e6ba6e8280d75e4404ab8674f7 --90e6ba6e8280d75e4404ab8674f7 Content-Type: text/plain; charset=ISO-8859-1 If you look at: https://reviews.apache.org/r/1668/diff/1/#index_header You would see that people other than me worry about trailing whitespace :-) On Sat, Aug 27, 2011 at 6:06 PM, Todd Lipcon wrote: > I've never understood the issue - why do people care so much about > trailing whitespace? > > I'm picky about whitespace/indentation/style since it makes code > easier to read, but whitespace at end of line is invisible! > > -Todd > > On Sat, Aug 27, 2011 at 6:51 AM, Ted Yu wrote: > > Hi, > > A big portion of review is on removing trailing whitespace in patch. > > I think contributors can help reduce the amount of time spent in this > > trivial task. > > The following description is for Mac OS X, but it is easy to customize > for > > your OS. See > > > http://stackoverflow.com/questions/149057/how-to-removing-trailing-whitespace-of-all-files-recursively > > > > 1. Generate patch as usual (e.g. 3900.addendum) > > 2. Use the following command on patch: > > sed -i .bak -E 's/ *$//g' 3900.addendum > > 3. The above operation would remove trailing whitespaces on lines not > > changed by the patch. So committer needs to use --ignore-whitespace > option > > when applying the patch. > > > > Your comments/ideas are welcome. > > > > > > -- > Todd Lipcon > Software Engineer, Cloudera > --90e6ba6e8280d75e4404ab8674f7--