Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (nike.apache.org: domain of saint.ack@gmail.com designates
 209.85.216.41 as permitted sender)
MIME-Version: 1.0
Sender: saint.ack@gmail.com
In-Reply-To: 
 <CAB5sDNKVW8Fb-5iCzd6pm2TpGkQvtS10CfF8dsUTV+_pWOxNrw@mail.gmail.com>
References: 
 <CAJL+TUQ9GVZrzajH-T-z_UqiZk28ExJ3iZNYD2_WD6a=AM3G2Q@mail.gmail.com>
	<CALte62zMqeTS++Awndkf2rmNxGcLHL9h65tR=N7bAWbRNvo4vg@mail.gmail.com>
	<CAK+1Ebg5Wug=AdMfCYJSNMiZDqWr9vE1gpfszSVHhZNPRZrByA@mail.gmail.com>
	<19B0D6EC092CA24CB061EF3CD535C92F64C3EA57@ASHBMBX05.resource.ds.bah.com>
	<CAB5sDNLuvPcQCPrGpMnqGajr5_pnNerM0qkmbALHWed0nw1j_A@mail.gmail.com>
	<CAB5sDNKVW8Fb-5iCzd6pm2TpGkQvtS10CfF8dsUTV+_pWOxNrw@mail.gmail.com>
Date: Wed, 6 Jul 2011 14:14:09 -0700
Message-ID: 
 <CADcMMgHn9jpZbODpL0zUyOuPDwDM3R-KM0AtPQL0VQtnuv3hcQ@mail.gmail.com>
Subject: Re: zoo.cfg vs hbase-site.xml
From: Stack <stack@duboce.net>
To: dev@hbase.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

I agree that we should be more consistent in how we get zk config
(Your original report looks like a bug Lars).  I also recently tripped
over the fact that hbase uses different names for one or two zk
configs.  We need to fix that too.
St.Ack

On Mon, Jul 4, 2011 at 8:59 AM, Jesse Yates <jesse.k.yates@gmail.com> wrote=
:
> Isn't that kind of the point though? If you drop in a zk config file on a
> machine, you should be able to update all your apps on that machine to th=
e
> new config.
> Whats more important though is being able to easily distribute a changed =
zk
> config across your cluster and simultaneously across multiple application=
s.
> Rather than rewriting the confs for a handful of applications, and possib=
ly
> making a mistake dealing with each application's own special semantics, a=
nd
> single conf to update everything just makes sense.
>
> I would lobby then that we make usage more consistent (as Lars recommends=
)
> and make some of the hbase conf values to more closely match the zk conf
> values (though hbase.${zk.value} is really not bad).
>
> -Jesse
>
>
> From: Ryan Rawson [ryanobjc@gmail.com]
>> Sent: Monday, July 04, 2011 5:25 AM
>> To: dev@hbase.apache.org
>> Subject: Re: zoo.cfg vs hbase-site.xml
>>
>> Should just fully deprecate zoo.cfg, it ended up being more trouble
>> than it was worth. =A0When you use zoo.cfg you cannot connect to more
>> than 1 cluster from a single JVM. =A0Annoying!
>>
>> On Sun, Jul 3, 2011 at 10:22 AM, Ted Yu <yuzhihong@gmail.com> wrote:
>> > I looked at conf/zoo_sample.cfg from zookeeper trunk. The naming of
>> > properties is different from the way we name
>> > "hbase.zookeeper.property.maxClientCnxns"
>> >
>> > e.g.
>> > # the port at which the clients will connect
>> > clientPort=3D2181
>> >
>> > FYI
>> >
>> > On Sun, Jul 3, 2011 at 9:53 AM, Lars George <lars.george@gmail.com>
>> wrote:
>> >
>> >> Hi,
>> >>
>> >> Usually the zoo.cfg overrides *all* settings off the hbase-site.xml
>> >> (including the ones from hbase-default.xml) - when present. But in so=
me
>> >> places we do not consider this, for example in HConnectionManager:
>> >>
>> >> =A0static {
>> >> =A0 =A0// We set instances to one more than the value specified for {=
@link
>> >> =A0 =A0// HConstants#ZOOKEEPER_MAX_CLIENT_CNXNS}. By default, the zk =
default
>> >> max
>> >> =A0 =A0// connections to the ensemble from the one client is 30, so i=
n that
>> >> case we
>> >> =A0 =A0// should run into zk issues before the LRU hit this value of =
31.
>> >> =A0 =A0MAX_CACHED_HBASE_INSTANCES =3D HBaseConfiguration.create().get=
Int(
>> >> =A0 =A0 =A0 =A0HConstants.ZOOKEEPER_MAX_CLIENT_CNXNS,
>> >> =A0 =A0 =A0 =A0HConstants.DEFAULT_ZOOKEPER_MAX_CLIENT_CNXNS) + 1;
>> >> =A0 =A0HBASE_INSTANCES =3D new LinkedHashMap<HConnectionKey,
>> >> HConnectionImplementation>(
>> >> =A0 =A0 =A0 =A0(int) (MAX_CACHED_HBASE_INSTANCES / 0.75F) + 1, 0.75F,=
 true) {
>> >> =A0 =A0 =A0 @Override
>> >> =A0 =A0 =A0protected boolean removeEldestEntry(
>> >> =A0 =A0 =A0 =A0 =A0Map.Entry<HConnectionKey, HConnectionImplementatio=
n> eldest) {
>> >> =A0 =A0 =A0 =A0 return size() > MAX_CACHED_HBASE_INSTANCES;
>> >> =A0 =A0 =A0 }
>> >> =A0 =A0};
>> >>
>> >>
>> >> This only reads it from hbase-site.xml+hbase-default.xml. This is
>> >> inconsistent, I think this should use ZKConfig.makeZKProps(conf) and
>> then
>> >> get the value.
>> >>
>> >> Thoughts?
>> >>
>> >> Lars
>> >>
>> >
>>
>