Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (nike.apache.org: domain of saint.ack@gmail.com designates
 209.85.216.176 as permitted sender)
MIME-Version: 1.0
Sender: saint.ack@gmail.com
In-Reply-To: 
 <CALte62wP=NaGt6CvtjZDQmwvyyawzrxjSciP0ym8+0R3WP8=rg@mail.gmail.com>
References: 
 <111361737.15600.1311367737810.JavaMail.tomcat@hel.zones.apache.org>
	<150237820.396.1311377229591.JavaMail.tomcat@hel.zones.apache.org>
	<CALte62wP=NaGt6CvtjZDQmwvyyawzrxjSciP0ym8+0R3WP8=rg@mail.gmail.com>
Date: Fri, 22 Jul 2011 21:31:16 -0700
Message-ID: 
 <CADcMMgEaNCf1YiRfEnh_k1fhcGEj4-mV+j5j=+u2AA-jQBmB=g@mail.gmail.com>
Subject: Re: [jira] [Commented] (HBASE-4127) HBaseAdmin : Don't modify table's
 name away
From: Stack <stack@duboce.net>
To: dev@hbase.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Try your proposal.  I don't think it will work.  It'll fail over in
RPC where expectation is that there is a null/default constructor on
every Writable.
St.Ack

On Fri, Jul 22, 2011 at 9:24 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> My proposal below would make default HTableDescriptor ctor package privat=
e.
>
> If there is no object, I will log a new JIRA.
>
> On Fri, Jul 22, 2011 at 4:27 PM, Ted Yu (JIRA) <jira@apache.org> wrote:
>
>>
>> =A0 =A0[
>> https://issues.apache.org/jira/browse/HBASE-4127?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1306984=
0#comment-13069840]
>>
>> Ted Yu commented on HBASE-4127:
>> -------------------------------
>>
>> +1 on the patch.
>>
>> Long term, we should hide this ctor, HTableDescriptor().
>> Its existence is to support the following pattern:
>> {code}
>> =A0 =A0 =A0hTableDescriptor =3D new HTableDescriptor();
>> =A0 =A0 =A0hTableDescriptor.readFields(fsDataInputStream);
>> {code}
>> I think we should replace this ctor with the following:
>> {code}
>> public HTableDescriptor getTableDescriptor(DataInputStream dataInputStre=
am)
>> {code}
>>
>> > HBaseAdmin : Don't modify table's name away
>> > -------------------------------------------
>> >
>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Key: HBASE-4127
>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 URL: https://issues.apache.org/jira/br=
owse/HBASE-4127
>> > =A0 =A0 =A0 =A0 =A0 =A0 Project: HBase
>> > =A0 =A0 =A0 =A0 =A0Issue Type: Bug
>> > =A0 =A0 =A0 =A0 =A0Components: client, master
>> > =A0 =A0Affects Versions: 0.92.0
>> > =A0 =A0 =A0 =A0 =A0 =A0Reporter: Nicolas Spiegelberg
>> > =A0 =A0 =A0 =A0 =A0 =A0Assignee: Nicolas Spiegelberg
>> > =A0 =A0 =A0 =A0 =A0 =A0Priority: Blocker
>> > =A0 =A0 =A0 =A0 Attachments: HBASE-4127.patch
>> >
>> >
>> > One of the developers was using the default constructor for
>> HTableDescriptor, which is sadly a bad constructor that should never be
>> used. It made the tablename empty in META & caused an ERROR cycle as reg=
ion
>> onlining kept failing. We should have never let this happen. Don't do ta=
ble
>> modifications if the HTableDescriptor name doesn't match the table name
>> passed in.
>>
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see: http://www.atlassian.com/software/jir=
a
>>
>>
>>
>