hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stack <st...@duboce.net>
Subject Re: JVMClusterUtil.startup method refactor
Date Fri, 15 Jul 2011 17:22:56 GMT
On Fri, Jul 15, 2011 at 10:20 AM, Akash Ashok <thehellmaker@gmail.com> wrote:
> Hi,
>    I was having a look at the org.apache.hadoop.hbase.util.JVMClusterUtil.
> The startup method has the following signature
>
> public static String startup(final List<JVMClusterUtil.MasterThread>
> masters,  final List<JVMClusterUtil.RegionServerThread> regionservers)
>
> The return type is a string which return the ActiveMaster Information in the
> string format which doesn't seem to be used anywhere. I am planning to make
> it a void return type and change so that it doesn't wait for the active
> master.
>

Why you making the change?

> Please do let me know if any1 finds an issue with this change?
>

Sure, as long as tests pass afterward.

Thanks Akash.
St.Ack

Mime
View raw message