hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash <thehellma...@gmail.com>
Subject Re: JVMClusterUtil.startup method refactor
Date Sun, 17 Jul 2011 05:13:13 GMT
Yes.. please review it . Wat I meant was that I wnt be changing the signature of the startup
method. But the patch is still a valid one :)

Sent from my iPhone

On Jul 17, 2011, at 10:24 AM, Stack <stack@duboce.net> wrote:

> So, should I review hbase-4008?  Thanks Akash.
> St.Ack
> 
> On Sat, Jul 16, 2011 at 10:04 AM, Akash Ashok <thehellmaker@gmail.com> wrote:
>> I decided against it as the change i was thinking about broke a lot of test
>> cases. So I'm gonna leave it as it is. :)
>> 
>> On Sat, Jul 16, 2011 at 2:10 PM, Akash Ashok <thehellmaker@gmail.com> wrote:
>> 
>>> 
>>> 
>>> On Fri, Jul 15, 2011 at 10:52 PM, Stack <stack@duboce.net> wrote:
>>> 
>>>> On Fri, Jul 15, 2011 at 10:20 AM, Akash Ashok <thehellmaker@gmail.com>
>>>> wrote:
>>>>> Hi,
>>>>>    I was having a look at the
>>>> org.apache.hadoop.hbase.util.JVMClusterUtil.
>>>>> The startup method has the following signature
>>>>> 
>>>>> public static String startup(final List<JVMClusterUtil.MasterThread>
>>>>> masters,  final List<JVMClusterUtil.RegionServerThread> regionservers)
>>>>> 
>>>>> The return type is a string which return the ActiveMaster Information
in
>>>> the
>>>>> string format which doesn't seem to be used anywhere. I am planning to
>>>> make
>>>>> it a void return type and change so that it doesn't wait for the active
>>>>> master.
>>>>> 
>>>> 
>>>> Why you making the change?
>>>> -- I am making this change because this would make the Fix for HBase4008
a
>>>> little neater as i could put the termination logic in the appropriate place.
>>>> and also the return value is used nowhere else
>>>> 
>>> 
>>> 
>>> 
>>>>> Please do let me know if any1 finds an issue with this change?
>>>>> 
>>>> 
>>>> Sure, as long as tests pass afterward.
>>>> -- Sure I shall run all the tests before submitting the patch
>>> 
>>> 
>>> 
>>> Thanks a lot
>>> Akash A
>>> 
>> 

Mime
View raw message