Return-Path: X-Original-To: apmail-hbase-dev-archive@www.apache.org Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C550E49FC for ; Tue, 31 May 2011 19:23:25 +0000 (UTC) Received: (qmail 20373 invoked by uid 500); 31 May 2011 19:23:25 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 20352 invoked by uid 500); 31 May 2011 19:23:25 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 20344 invoked by uid 99); 31 May 2011 19:23:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2011 19:23:25 +0000 X-ASF-Spam-Status: No, hits=-2.8 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received-SPF: unknown (nike.apache.org: error in processing during lookup of mingma@ebay.com) Received: from [216.113.175.152] (HELO den-mipot-001.corp.ebay.com) (216.113.175.152) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2011 19:23:17 +0000 DomainKey-Signature: s=corp; d=ebay.com; c=nofws; q=dns; h=X-EBay-Corp:X-IronPort-AV:Received:Received:From:To:Date: Subject:Thread-Topic:Thread-Index:Message-ID: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:acceptlanguage:x-ems-proccessed: x-ems-stamp:Content-Type:MIME-Version:X-CFilter; b=Q7pvPB003sRV1i1IjK6ANu7/mkQ0VNoZr8F1r5bnJjWHlMQ9EAUtKSK2 sL5YKByO1Lvw/QrPNhK53/ajLzb+800D91MiPpagbWnQ6brT5TUnbOtnp qRp/Ld0R9xE5ADB; DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ebay.com; i=mingma@ebay.com; q=dns/txt; s=corp; t=1306869796; x=1338405796; h=from:to:date:subject:message-id:mime-version; bh=EZjs2FIYpFLJn3A93VCiF5MsG3Cyq/uLlMMSsQJL0p8=; b=kgMD9bD62NmWX5/BStXsj+EDc+ZQZvrFt2FbUDJbCvG44D4kixJqAZ3f UHC1VaDyQuDePDYauaScAnQ8gSlKaRtLOxAXqc8XYed/sgzoPKzHtjKPQ ODQw6Ys+BEcbpN/; X-EBay-Corp: Yes X-IronPort-AV: E=Sophos;i="4.65,299,1304319600"; d="scan'208,217";a="2233272" Received: from den-vtenf-002.corp.ebay.com (HELO DEN-MEXHT-001.corp.ebay.com) ([10.101.112.213]) by den-mipot-001.corp.ebay.com with ESMTP; 31 May 2011 12:22:51 -0700 Received: from DEN-MEXMS-001.corp.ebay.com ([10.241.16.225]) by DEN-MEXHT-001.corp.ebay.com ([10.241.17.52]) with mapi; Tue, 31 May 2011 13:22:51 -0600 From: "Ma, Ming" To: "dev@hbase.apache.org" Date: Tue, 31 May 2011 13:22:50 -0600 Subject: minor issues found in code reading Thread-Topic: minor issues found in code reading Thread-Index: AcwfyCGpsVLgC0FbRcOACnQ3qe6/Fg== Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US x-ems-proccessed: 10SqDH0iR7ekR7SRpKqm5A== x-ems-stamp: FUBTbqU1A/w3BnnAbo5zsw== Content-Type: multipart/alternative; boundary="_000_D10C58C9BA49DC40AA68056049009BF3642CCAF3E6DENMEXMS001co_" MIME-Version: 1.0 X-CFilter: Scanned X-Virus-Checked: Checked by ClamAV on apache.org --_000_D10C58C9BA49DC40AA68056049009BF3642CCAF3E6DENMEXMS001co_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, I find some minor issues during code reading, should we file a bug for each= one or someone can just fix it along with other issues? This is from on th= e latest thunk code. master/handler/EnableTableHandler.java, line 98, the log say "... are onlin= e", it seems it should be "... aren't online". client/HConnectionManger.java, line 984, 985, "value =3D ..."isn't needed. Thanks. Ming --_000_D10C58C9BA49DC40AA68056049009BF3642CCAF3E6DENMEXMS001co_--