Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of yuzhihong@gmail.com
 designates 74.125.83.169 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=bUQ0WJ+mrAvP/E6hXf8MDsTa+Wdt3esLpWfO5fuQ7dZIRbboLKZbh7iisBmoygIXcK
         cpE//2x1GMpRWrjuOUSEiD5oBebLL98UoJHtiAiDhA9bhFNTwj6Y0iyv5gAwOLaUBQeU
         lzSOcb/xSnj9UlYTe6Lf2grx5Nf2LpiyiHiOE=
MIME-Version: 1.0
In-Reply-To: <BANLkTinVC=RaygOwTdFSJx8qcumxPvXu5g@mail.gmail.com>
References: <BANLkTinVC=RaygOwTdFSJx8qcumxPvXu5g@mail.gmail.com>
Date: Mon, 30 May 2011 07:11:16 -0700
Message-ID: <BANLkTin3yf_+B_5wvxSpMgaDM9ES03WMJg@mail.gmail.com>
Subject: Re: Memstore Limit?
From: Ted Yu <yuzhihong@gmail.com>
To: dev@hbase.apache.org
Content-Type: multipart/alternative; boundary=bcaec520f05351c7da04a47edc11

--bcaec520f05351c7da04a47edc11
Content-Type: text/plain; charset=ISO-8859-1

See https://issues.apache.org/jira/browse/HBASE-3934

Thanks Lars

On Mon, May 30, 2011 at 7:02 AM, Lars George <lars.george@gmail.com> wrote:

> Hi,
>
> See below from MemStoreFlusher.java (trunk):
>
>  static long getMemStoreLimit(final long max, final float limit,
>      final float defaultLimit) {
>    if (limit >= 0.9f || limit < 0.1f) {
>      LOG.warn("Setting global memstore limit to default of " + defaultLimit
> +
>        " because supplied value outside allowed range of 0.1 -> 0.9");
>    }
>    return (long)(max * limit);
>  }
>
> The log message says it is using defaultLimit, but the code is not.
> Should we fix either?
>
> Lars
>

--bcaec520f05351c7da04a47edc11--