hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lars George <lars.geo...@gmail.com>
Subject Memstore Limit?
Date Mon, 30 May 2011 14:02:21 GMT
Hi,

See below from MemStoreFlusher.java (trunk):

  static long getMemStoreLimit(final long max, final float limit,
      final float defaultLimit) {
    if (limit >= 0.9f || limit < 0.1f) {
      LOG.warn("Setting global memstore limit to default of " + defaultLimit +
        " because supplied value outside allowed range of 0.1 -> 0.9");
    }
    return (long)(max * limit);
  }

The log message says it is using defaultLimit, but the code is not.
Should we fix either?

Lars

Mime
View raw message