hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stack <st...@duboce.net>
Subject Re: 3744-addendum-for-TestAdmin.patch need apply to branch and trunk
Date Fri, 06 May 2011 20:04:14 GMT
I applied the addendum.
St.Ack

On Tue, May 3, 2011 at 11:32 AM, Ted Yu <yuzhihong@gmail.com> wrote:
> I am waiting for TestAdmin to fail again in trunk :-)
>
> On Tue, May 3, 2011 at 11:22 AM, Jean-Daniel Cryans <jdcryans@apache.org>wrote:
>
>> I reviewed that patch and I'm waiting for a new version of it to commit it.
>>
>> J-D
>>
>> On Mon, May 2, 2011 at 8:02 PM, Gaojinchao <gaojinchao@huawei.com> wrote:
>> > Only run TestAdmin is success. But in my cluster run all test case, it
>> always fails .
>> > 1.    I think it need apply 3744-addendum-for-TestAdmin.patc<
>> https://issues.apache.org/jira/secure/attachment/12477493/3744-addendum-for-TestAdmin.patch>h
>> by Ted Yu.
>> > The reason:
>> > In version 0.90.2.  Region can assigned to Region server by this code
>> > // 5. Trigger immediate assignment of the regions in round-robin fashion
>> >   List<HServerInfo> servers = serverManager.getOnlineServersList();
>> >   try {
>> >     this.assignmentManager.assignUserRegions(Arrays.asList(newRegions),
>> servers);    // It waits for 10 minites.
>> >   } catch (InterruptedException ie) {
>> >     LOG.error("Caught " + ie + " during round-robin assignment");
>> >     throw new IOException(ie);
>> >   }
>> >
>> > But In version 0.90.3. Region can't assigned to region server.
>> (HBASE-3744 introduced a change in how createTable() works by Ted Yu)
>> >
>> >  // 5. Trigger immediate assignment of the regions in round-robin fashion
>> >   List<HServerInfo> servers = serverManager.getOnlineServersList();
>> >   this.assignmentManager.bulkAssignUserRegions(newRegions, servers,
>> sync);        // It doesn't wait for.
>> >
>> > So function verifyRoundRobinDistribution can't get address and throws
>> exceptions
>> > List<HRegionInfo> regs = server2Regions.get(server);
>> >
>> > public int hashCode() {
>> >   int result = address.hashCode();
>>       // Region can't be assigned, So it seems like throw some exceptions.
>> >   result ^= stringValue.hashCode();
>> >   return result;
>> >  }
>> >
>>
>

Mime
View raw message