Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 82039 invoked from network); 1 Apr 2011 04:18:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Apr 2011 04:18:52 -0000 Received: (qmail 19664 invoked by uid 500); 1 Apr 2011 04:18:50 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 19567 invoked by uid 500); 1 Apr 2011 04:18:49 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 19554 invoked by uid 99); 1 Apr 2011 04:18:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Apr 2011 04:18:48 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of yuzhihong@gmail.com designates 209.85.161.41 as permitted sender) Received: from [209.85.161.41] (HELO mail-fx0-f41.google.com) (209.85.161.41) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Apr 2011 04:18:41 +0000 Received: by fxm18 with SMTP id 18so3273179fxm.14 for ; Thu, 31 Mar 2011 21:18:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=kViIWONEvOFNBzn4Wz+luqNCuE+97dV+qnvpMaH2CKM=; b=VFIbLn9NBCP7b1tldYfQgMMCZTHAA8VstJ7+FwLhphMV3HcW6t/0sXCTxujQb1UxGe sPiB0MCioaZ62wlsXLyxVKdGpAGb7Mzgo3d4/qrx/1R4mvJ7KmzY8oVkj2UPHYNglzmi VhWF7umd9a+cuZH+hyaMX4dhJrKrIFFmX08+c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=lW/eM1lUu9/mo7ciMgJaEA3EdnlIZf01C5MSMmSYSvAQ/yK4ywXD+3h31GD7TmKPdc VTwMhrkW9MG6gGDbWOq8JrqEshBjQY09vVS5rpWS1lkiq/CwV/8sChA59OgE8+I622gU r9NFvGIOT0ISDnw9pIpkEYrQZ/rJma9by240w= MIME-Version: 1.0 Received: by 10.223.66.69 with SMTP id m5mr3682321fai.14.1301631500871; Thu, 31 Mar 2011 21:18:20 -0700 (PDT) Received: by 10.223.75.196 with HTTP; Thu, 31 Mar 2011 21:18:20 -0700 (PDT) In-Reply-To: References: Date: Thu, 31 Mar 2011 21:18:20 -0700 Message-ID: Subject: Re: ColumnInterpreter and HbaseObjectWritable Was: HbaseObjectWritable and UnsupportedOperationException From: Ted Yu To: dev@hbase.apache.org Cc: Himanshu Vashishtha Content-Type: multipart/alternative; boundary=0015174c3dba3ce791049fd3b32c X-Virus-Checked: Checked by ClamAV on apache.org --0015174c3dba3ce791049fd3b32c Content-Type: text/plain; charset=ISO-8859-1 I found the one more benefit of using (enhanced) interpreter. We load AggregateProtocolImpl.class into CoprocessorHost. Interpreter feeds various values (such as Long.MIN_VALUE) of concrete type (Long) into AggregateProtocolImpl. This simplifies class loading for CoprocessorHost Cheers On Thu, Mar 31, 2011 at 11:37 AM, Ted Yu wrote: > Renaming the subject to better reflect the nature of further discussion. > > There're two considerations for my current implementation attached to > HBASE-1512. > 1. User shouldn't modify HbaseObjectWritable directly for the new class > which is to be executed on region server. > 2. The reason for introducing interpreter is that we (plan to) store > objects of MeasureWritable, a relatively complex class, in hbase. Using > interpreter would give us flexibility in computing aggregates. > > Cheers > > On Thu, Mar 31, 2011 at 10:01 AM, Himanshu Vashishtha < > hvashish@cs.ualberta.ca> wrote: > >> Hello Ted, >> Did you add a new class: LongColumnInterpreter. Is this the new argument >> type you want to define to pass along rpcs. For all such "new" argument >> types, they should be supported/backed up with in the HbaseObjectWritable >> class to read/write it on wire. Do we really need it, just wondering. >> >> Himanshu >> >> On Thu, Mar 31, 2011 at 10:52 AM, Ted Yu wrote: >> >> > Hi, >> > When I experimented with HBASE-1512, I got the following from >> > HbaseObjectWritable: >> > java.lang.UnsupportedOperationException: No code for unexpected class >> > >> > >> org.apache.hadoop.hbase.client.coprocessor.AggregationClient$1LongColumnInterpreter >> > >> > I think there was initiative to support dynamic class registration in >> > HbaseObjectWritable >> > >> > If someone can enlighten me on the above, that would be great. >> > >> > > --0015174c3dba3ce791049fd3b32c--