hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhoushuaifeng <zhoushuaif...@huawei.com>
Subject Majorcompactchecker problem in 0.90.1
Date Fri, 01 Apr 2011 01:16:41 GMT
Hi,

I found there may be some problem with majorcompactchecker in 0.90.1:

In the function store.isMajorCompaction:
      if (filesToCompact.size() == 1) {
        // Single file
        StoreFile sf = filesToCompact.get(0);
        long oldest =
            (sf.getReader().timeRangeTracker == null) ?
                Long.MIN_VALUE :
                now - sf.getReader().timeRangeTracker.minimumTimestamp;
        if (sf.isMajorCompaction() &&
            (this.ttl == HConstants.FOREVER || oldest < this.ttl)) {
          if (LOG.isDebugEnabled()) {
            LOG.debug("Skipping major compaction of " + this.storeNameStr +
                " because one (major) compacted file only and oldestTime " +
                oldest + "ms is < ttl=" + this.ttl);
          }
        }
      } else {
When there is only one storefile in the store, and some keyvalues' TTL are overtime, the majorcompactchecker
should send this region to the compactquene and run a majorcompact to clean these outdated
data. But according to the code in 0.90.1, it will do nothing. I think this may be a problem
should be fixed.


Zhou Shuaifeng(Frank)


-------------------------------------------------------------------------------------------------------------------------------------
This e-mail and its attachments contain confidential information from HUAWEI, which
is intended only for the person or entity whose address is listed above. Any use of the
information contained herein in any way (including, but not limited to, total or partial
disclosure, reproduction, or dissemination) by persons other than the intended
recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender
by
phone or email immediately and delete it!


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message