Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 55480 invoked from network); 24 Mar 2011 04:07:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Mar 2011 04:07:53 -0000 Received: (qmail 19755 invoked by uid 500); 24 Mar 2011 04:07:52 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 19722 invoked by uid 500); 24 Mar 2011 04:07:52 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 19713 invoked by uid 99); 24 Mar 2011 04:07:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2011 04:07:52 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of saint.ack@gmail.com designates 209.85.161.41 as permitted sender) Received: from [209.85.161.41] (HELO mail-fx0-f41.google.com) (209.85.161.41) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2011 04:07:46 +0000 Received: by fxm18 with SMTP id 18so10502694fxm.14 for ; Wed, 23 Mar 2011 21:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=Gov6Hq/dmorjrPlGbXRiJcfxHy3prjRLuifzb32iIpY=; b=v+H8jpXq9ztM0s+y5NXAdBmnUiyr4H2MpETmr7Uz/M63p0n8gdkav+amYnCzpDTR00 gP1S0Qn+udkMfrfV0trvktypX3ltTIgqnRrzR9p2sB1dRIRofs1zota9/XEFPXeQSiIT vxjpLkHyL8Cwt4q1cUTJUneqrEyetZ8c2QRu4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=wKgv2jG5enPDUFycQdIVjysQ11ujvBApZXXWaX5aRptd1Otxn/eNV4ba6V10WzHab2 Z4gadi9FMuYbCBkYx0UzoidmkGEHjTMv4w+0OFuvF0iQbbh0Lh5Ub3v5MAEdvW9hoKIu IN8kprlBzL+l75ODgznLUacS0I+XXXQ4is22Q= MIME-Version: 1.0 Received: by 10.223.63.212 with SMTP id c20mr956518fai.37.1300939645733; Wed, 23 Mar 2011 21:07:25 -0700 (PDT) Sender: saint.ack@gmail.com Received: by 10.223.87.4 with HTTP; Wed, 23 Mar 2011 21:07:25 -0700 (PDT) In-Reply-To: References: Date: Wed, 23 Mar 2011 21:07:25 -0700 X-Google-Sender-Auth: TjXQbLqvufB92OKGu61JH1bPBP4 Message-ID: Subject: Re: hbase-2001 added getZooKeeperWatcher and getCatalogTracker to RegionServerServices but these two methods are in Server From: Stack To: HBase Dev List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org It doesn't look like these additions are actually used so I made https://issues.apache.org/jira/browse/HBASE-3698. If I get a +1, I'll commit. Thanks, St.Ack On Wed, Mar 23, 2011 at 8:44 PM, Stack wrote: > It looks like hbase-2001 added some overlap between the Server and > RegionServerServices Interfaces. =A0Here's the commit that added it: > > commit c1dd72441d376e62615a0ec92f09515521ccb99b > Author: Andrew Kyle Purtell > Date: =A0 Sat Nov 20 01:23:39 2010 +0000 > > =A0 =A0HBASE-2001 Coprocessors: Colocate user code with regions > > =A0 =A0git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1037102 > 13f79535-47bb-0310-9956-ffa450edef68 > > Is the overlap really necessary? =A0At a minimum it looks untidy. > Beyond that, it makes mocking a little bit more painful. > > What ye reckon? > > St.Ack >