hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stack <st...@duboce.net>
Subject Re: hbase-2001 added getZooKeeperWatcher and getCatalogTracker to RegionServerServices but these two methods are in Server
Date Thu, 24 Mar 2011 04:07:25 GMT
It doesn't look like these additions are actually used so I made
https://issues.apache.org/jira/browse/HBASE-3698.  If I get a +1, I'll
commit.

Thanks,
St.Ack

On Wed, Mar 23, 2011 at 8:44 PM, Stack <stack@duboce.net> wrote:
> It looks like hbase-2001 added some overlap between the Server and
> RegionServerServices Interfaces.  Here's the commit that added it:
>
> commit c1dd72441d376e62615a0ec92f09515521ccb99b
> Author: Andrew Kyle Purtell <apurtell@apache.org>
> Date:   Sat Nov 20 01:23:39 2010 +0000
>
>    HBASE-2001 Coprocessors: Colocate user code with regions
>
>    git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1037102
> 13f79535-47bb-0310-9956-ffa450edef68
>
> Is the overlap really necessary?  At a minimum it looks untidy.
> Beyond that, it makes mocking a little bit more painful.
>
> What ye reckon?
>
> St.Ack
>

Mime
View raw message