Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 5682 invoked from network); 21 Feb 2011 15:26:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Feb 2011 15:26:57 -0000 Received: (qmail 85423 invoked by uid 500); 21 Feb 2011 15:26:56 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 85171 invoked by uid 500); 21 Feb 2011 15:26:54 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 85163 invoked by uid 99); 21 Feb 2011 15:26:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Feb 2011 15:26:53 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ophchu@gmail.com designates 209.85.215.47 as permitted sender) Received: from [209.85.215.47] (HELO mail-ew0-f47.google.com) (209.85.215.47) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Feb 2011 15:26:44 +0000 Received: by ewy28 with SMTP id 28so2184426ewy.6 for ; Mon, 21 Feb 2011 07:26:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :subject:content-type; bh=4vUlA5SelrHzhqDdQRUYhyIXwsQlJKL6RYaFSXP3Xr4=; b=Aogg19GePaohzkS4BOosBLwukVDRPqi9n2l6Rn0PT+6aMYN9QeWP5OurAWnHMMFRYg mIRKD/7NNY3yfeby3Gwu1NWJ+Tq0Jpk85zJY3nI/W0BsjkrtDrYImojPT7L89psLSQl6 4BPAlUi+AtVgz5r8gXNGGxR/I9REWFVkDPVIg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; b=mOCFEAZ3Cv4+rWbkLfnAia2D61XCnMFFTBkwAA3ml7meRWP2TlxIKSXwlVawfWYd8S bMJJzNTCLqydz7k7Ifx0Wyxmnt6qzLeJYCuwd5Pe27ie3eDLHFCcQMl3AI+5Zg9ccIAp 7UuiNlMaknkfCmJ9vuDFFkT2tuScfQcIMdcRM= Received: by 10.14.15.223 with SMTP id f71mr1687132eef.37.1298301983661; Mon, 21 Feb 2011 07:26:23 -0800 (PST) Received: from [192.168.22.190] ([195.62.30.20]) by mx.google.com with ESMTPS id q52sm4998218eei.3.2011.02.21.07.26.16 (version=SSLv3 cipher=OTHER); Mon, 21 Feb 2011 07:26:18 -0800 (PST) Message-ID: <4D628409.4090300@gmail.com> Date: Mon, 21 Feb 2011 17:26:01 +0200 From: Ophir Cohen User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b3pre Thunderbird/3.1.7 MIME-Version: 1.0 To: dev@hbase.apache.org Subject: Coding conventions Content-Type: multipart/alternative; boundary="------------080003030703070908090901" X-Virus-Checked: Checked by ClamAV on apache.org --------------080003030703070908090901 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi All, I started to work on my first issue: https://issues.apache.org/jira/browse/HBASE-2965 and I have few questions regarding coding conventions: 1. Do you have any convention for configuration paramters names (those that comes from the Configuration class)? 2. I saw few places that uses '+' to concat strings. Is that OK or you prefer other means (say StringBuilder)? 3. Generally do you prefer to pass between classes the Job class or the Configuration class (assuming, of course, that both of them holds the needed data)? Thanks for the answer, Ophir --------------080003030703070908090901--