hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stack <st...@duboce.net>
Subject Re: One issue in HMaster Bootstrap when run HBase 0.20.6 on Hadoop 0.21
Date Fri, 07 Jan 2011 06:01:26 GMT
On Thu, Jan 6, 2011 at 7:12 PM, mac fang <mac.hadoop@gmail.com> wrote:
> I checked the code, and found there have some differs:
>
> 1. In Store (HBase 0.20.3)
>
>    this.homedir = getStoreHomedir(basedir, info.getEncodedName(),
>      family.getName());
>    this.region = region;
>    this.family = family;
>    this.fs = fs;
>    this.conf = conf;
>    this.blockcache = family.isBlockCacheEnabled();
>    this.blocksize = family.getBlocksize();
>    this.compression = family.getCompression();
>    this.comparator = info.getComparator();
>    this.comparatorIgnoringType =
> this.comparator.getComparatorIgnoringType();
>    ##########################################################
>    if (null!=this.homedir && !this.fs.exists(this.homedir)) {
>        if (!this.fs.mkdirs(this.homedir))
>          throw new IOException("Failed create of: " +
> this.homedir.toString());
>      }
>     ##########################################################
>


I don't see that in 0.20.3.  Here is what shipped with 0.20.3:

http://svn.apache.org/viewvc/hbase/tags/0.20.3/src/java/org/apache/hadoop/hbase/regionserver/Store.java?view=markup

See down around line #176.

I went back through a good few revisions and can't seem to find your
snippet above.

I looked in TRUNK and I see this near head of the Store constructor:

    if (!this.fs.exists(this.homedir)) {
      if (!this.fs.mkdirs(this.homedir))
        throw new IOException("Failed create of: " + this.homedir.toString());
    }

So, it came back?

I could be wrong, did mkdir change in 0.21? It doesn't autocreate
intermediate dirs now?  Is that the issue?

Let us know how your work getting things going on 0.21 goes.  Will be
interested to hear.

St.Ack


>
>  But in Storre.java (0.20.6)
>
> there is NO
>
>    if (null!=this.homedir && !this.fs.exists(this.homedir)) {
>        if (!this.fs.mkdirs(this.homedir))
>          throw new IOException("Failed create of: " +
> this.homedir.toString());
>      }
>
> Can anyone help me to check out why there has some changes? Since I am
> confused, i only change the Hadoop Version, but this code differs is NOT
> about Hadoop, it is a change in HBase.
>
>
> Thanks in Advance.
>
> Regards
> macf
>

Mime
View raw message